Skip to content

Commit 589bbdb

Browse files
committed
corrected docs, improved wait condition
1 parent 521569f commit 589bbdb

3 files changed

Lines changed: 9 additions & 13 deletions

File tree

docs/modules/druid/examples/getting_started/getting_started.sh

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,8 @@ exit 1
5555
;;
5656
esac
5757

58-
# As of SDP 26.3 CRDs are managed by the operator not helm, so there should be an initial delay
59-
# to allow the CRDs to be detected
60-
sleep 10
58+
# TODO: Remove once https://github.com/stackabletech/issues/issues/828 has been implemented (see that issue for details).
59+
until kubectl get crd druidclusters.druid.stackable.tech >/dev/null 2>&1; do echo "Waiting for CRDs to be installed" && sleep 1; done
6160

6261
echo "Installing ZooKeeper from zookeeper.yaml"
6362
# tag::install-zookeeper[]

docs/modules/druid/examples/getting_started/getting_started.sh.j2

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,9 +55,8 @@ exit 1
5555
;;
5656
esac
5757

58-
# As of SDP 26.3 CRDs are managed by the operator not helm, so there should be an initial delay
59-
# to allow the CRDs to be detected
60-
sleep 10
58+
# TODO: Remove once https://github.com/stackabletech/issues/issues/828 has been implemented (see that issue for details).
59+
until kubectl get crd druidclusters.druid.stackable.tech >/dev/null 2>&1; do echo "Waiting for CRDs to be installed" && sleep 1; done
6160

6261
echo "Installing ZooKeeper from zookeeper.yaml"
6362
# tag::install-zookeeper[]

docs/modules/druid/pages/getting_started/first_steps.adoc

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -106,20 +106,18 @@ simple-hdfs-namenode-default 2/2 6m
106106
simple-zk-server-default 3/3 7m
107107
----
108108

109-
Ideally you use `stackablectl stacklet list` to find out the address the Druid router is reachable at and use that address.
109+
=== Ingest example data
110110

111-
As an alternative, you can create a port-forward for the Druid Router:
111+
Next, ingest some example data using the web interface.
112+
You can either use `stackablectl stacklet list` to find out the address the Druid router is reachable at and use that address, or you can create a port-forward for the Druid Router:
112113

114+
[source,bash]
113115
----
114-
include::example$getting_started/getting_started.sh[tag=port-forwarding]
116+
kubectl port-forward svc/simple-druid-router 9088 > /dev/null 2>&1 &
115117
----
116118

117-
=== Ingest example data
118-
119-
Next, ingest some example data using the web interface.
120119
If you prefer to use the command line instead, follow the instructions in the collapsed section below.
121120

122-
123121
[#ingest-cmd-line]
124122
.Alternative: Using the command line
125123
[%collapsible]

0 commit comments

Comments
 (0)