Skip to content

Commit c504c3b

Browse files
committed
fix: remove c&p hive references enum / method comments
1 parent 37e2dd9 commit c504c3b

2 files changed

Lines changed: 3 additions & 7 deletions

File tree

extra/crds.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1488,7 +1488,6 @@ spec:
14881488
14891489
Please note that - due to license issues - we don't ship the mysql driver, you need to add
14901490
it it yourself.
1491-
See <https://docs.stackable.tech/home/stable/hive/usage-guide/database-driver/> for details.
14921491
properties:
14931492
credentialsSecretName:
14941493
description: |-

rust/operator-binary/src/crd/database.rs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,19 +28,16 @@ pub enum MetadataDatabaseConnection {
2828
///
2929
/// Please note that - due to license issues - we don't ship the mysql driver, you need to add
3030
/// it it yourself.
31-
/// See <https://docs.stackable.tech/home/stable/hive/usage-guide/database-driver/> for details.
3231
Mysql(MysqlConnection),
3332

3433
// Docs are on the struct
3534
Derby(DerbyConnection),
36-
// We don't support generic (yet?), as we need to tell the metastore the `--dbtype` on startup,
37-
// which is not known for generic connection. We could e.g. create a new struct with
38-
// #[serde(flatten)] of the GenericJdbcDatabaseConnection and an additional field
39-
// `metastoreDbType` (or similar).
35+
// We don't support generic as druid only offers the types mentioned above for metadata storage
36+
// See <https://druid.apache.org/docs/latest/design/metadata-storage/>
4037
}
4138

4239
impl MetadataDatabaseConnection {
43-
/// Name of the database as it should be passed using `METADATA_STORAGE_TYPE` property.
40+
/// Name of the database as it should be passed using `METADATA_STORAGE_TYPE` ("druid.metadata.storage.type") property.
4441
pub fn as_db_type(&self) -> &str {
4542
match self {
4643
MetadataDatabaseConnection::Postgresql(_) => "postgresql",

0 commit comments

Comments
 (0)