pre commit

Author: maltesander

rust/operator-binary/src/crd/mod.rs

@@ -774,10 +774,8 @@ impl HbaseRole {
         }
     }
 
-    pub fn metrics_port_name(&self) -> &str {
-        match self {
-            _ => HBASE_METRICS_PORT_NAME,
-        }
+    pub fn metrics_port_name() -> &'static str {
+        HBASE_METRICS_PORT_NAME
     }
 }
 

rust/operator-binary/src/hbase_controller.rs

@@ -765,7 +765,7 @@ pub fn build_rolegroup_metrics_service(
     resolved_product_image: &ResolvedProductImage,
 ) -> Result<Service, Error> {
     let ports = vec![ServicePort {
-        name: Some(hbase_role.metrics_port_name().to_owned()),
+        name: Some(HbaseRole::metrics_port_name().to_owned()),
         port: i32::from(hbase_role.metrics_port()),
         protocol: Some("TCP".to_owned()),
         ..ServicePort::default()

tests/templates/kuttl/logging/test_log_aggregation.py

@@ -23,9 +23,9 @@ def check_sent_events():
         },
     )
 
-    assert (
-        response.status_code == 200
-    ), "Cannot access the API of the vector aggregator."
+    assert response.status_code == 200, (
+        "Cannot access the API of the vector aggregator."
+    )
 
     result = response.json()
 
@@ -35,13 +35,13 @@ def check_sent_events():
         componentId = transform["componentId"]
 
         if componentId == "filteredInvalidEvents":
-            assert (
-                sentEvents is None or sentEvents["sentEventsTotal"] == 0
-            ), "Invalid log events were sent."
+            assert sentEvents is None or sentEvents["sentEventsTotal"] == 0, (
+                "Invalid log events were sent."
+            )
         else:
-            assert (
-                sentEvents is not None and sentEvents["sentEventsTotal"] > 0
-            ), f'No events were sent in "{componentId}".'
+            assert sentEvents is not None and sentEvents["sentEventsTotal"] > 0, (
+                f'No events were sent in "{componentId}".'
+            )
 
 
 if __name__ == "__main__":