Skip to content

Commit b562ea9

Browse files
Apply suggestions from code review
Co-authored-by: Techassi <git@techassi.dev>
1 parent 5d2b158 commit b562ea9

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

docs/modules/hbase/pages/usage-guide/monitoring.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ and the clients scraping the metrics endpoint need to authenticate against it. T
1616
between Kubernetes Pods with the xref:home:secret-operator:index.adoc[Secret Operator].
1717

1818
When using Prometheus `ServiceMonitor` for scraping, the `address` label needs relabeling to use the `headless` Service instead of the
19-
`metrics` Service. This is because per default Prometheus targets the Pod IPs as endpoints, but since the Pod IPs are not
19+
`metrics` Service. This is because by default Prometheus targets the Pod IPs as endpoints, but since the Pod IPs are not
2020
part of the certificate, the authentication will fail. Instead, the FQDN of the Pods, which can be added to the certificate, is used, but
2121
this FQDN is only available through the `headless` Service.
2222

rust/operator-binary/src/crd/mod.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -719,7 +719,8 @@ impl HbaseRole {
719719
}
720720

721721
/// Returns required port name and port number tuples depending on the role.
722-
/// Hbase versions 2.6.* will have two ports for each role. The metrics are available over the
722+
///
723+
/// Hbase versions 2.6.* will have two ports for each role. The metrics are available on the
723724
/// UI port.
724725
pub fn ports(&self, hbase: &v1alpha1::HbaseCluster) -> Vec<(String, u16)> {
725726
vec![

0 commit comments

Comments
 (0)