replace version with compile-time constant

Author: adwk67

rust/operator-binary/src/controller/validate.rs

@@ -64,15 +64,18 @@ pub struct ValidatedRoleGroupConfig {
 pub fn validate_cluster(
     hbase: &v1alpha1::HbaseCluster,
     image_repository: &str,
-    pkg_version: &str,
     product_config_manager: &ProductConfigManager,
     zookeeper_connection_information: ZookeeperConnectionInformation,
     hbase_opa_config: Option<HbaseOpaConfig>,
 ) -> Result<ValidatedCluster, Error> {
     let resolved_product_image = hbase
         .spec
         .image
-        .resolve(CONTAINER_IMAGE_BASE_NAME, image_repository, pkg_version)
+        .resolve(
+            CONTAINER_IMAGE_BASE_NAME,
+            image_repository,
+            crate::built_info::PKG_VERSION,
+        )
         .context(ResolveProductImageSnafu)?;
 
     let roles = hbase.build_role_properties().context(RolePropertiesSnafu)?;

rust/operator-binary/src/hbase_controller.rs

@@ -319,7 +319,6 @@ pub async fn reconcile_hbase(
     let validated = crate::controller::validate::validate_cluster(
         hbase,
         &ctx.operator_environment.image_repository,
-        crate::built_info::PKG_VERSION,
         &ctx.product_config,
         dereferenced.zookeeper_connection_information,
         dereferenced.hbase_opa_config,