fix: consolidate STACKABE_LOG_DIR import; remove empty vec allocation; commet region mover timeout

Author: maltesander

rust/operator-binary/src/controller/build/properties/hbase_site.rs

@@ -55,7 +55,9 @@ pub fn build(
 
     config.extend(zookeeper_config);
     config.extend(kerberos_config);
-    config.extend(opa_config.map_or(vec![], |config| config.hbase_site_config()));
+    if let Some(opa_config) = opa_config {
+        config.extend(opa_config.hbase_site_config());
+    }
 
     // Set flag to override default behaviour, which is that the
     // RPC client should bind the client address (forcing outgoing

rust/operator-binary/src/controller/build/properties/product_logging/mod.rs

@@ -1,11 +1,10 @@
 //! Renders the logging config files (`log4j2.properties` and the Vector agent config)
 //! assembled into the rolegroup `ConfigMap`.
 
-pub use stackable_operator::v2::product_logging::framework::STACKABLE_LOG_DIR;
 use stackable_operator::{
     memory::{BinaryMultiple, MemoryQuantity},
     product_logging::{self, spec::AutomaticContainerLogConfig},
-    v2::product_logging::framework::ValidatedContainerLogConfigChoice,
+    v2::product_logging::framework::{STACKABLE_LOG_DIR, ValidatedContainerLogConfigChoice},
 };
 
 pub const MAX_HBASE_LOG_FILES_SIZE: MemoryQuantity = MemoryQuantity {

rust/operator-binary/src/controller/build/region_mover.rs

@@ -7,7 +7,12 @@ use stackable_operator::shared::time::Duration;
 
 use crate::crd::AnyServiceConfig;
 
+/// Fallback region-mover timeout, used only when no graceful shutdown timeout is set. In practice
+/// the merged config always defaults `graceful_shutdown_timeout` (60m for region servers), so this
+/// is a defensive default; it mirrors that 60m default minus [`DEFAULT_REGION_MOVER_DELTA_TO_SHUTDOWN`].
 const DEFAULT_REGION_MOVER_TIMEOUT: Duration = Duration::from_minutes_unchecked(59);
+/// Time reserved before the graceful shutdown deadline, subtracted from the configured timeout so
+/// the region move finishes before the pod is terminated.
 const DEFAULT_REGION_MOVER_DELTA_TO_SHUTDOWN: Duration = Duration::from_minutes_unchecked(1);
 
 impl AnyServiceConfig {

rust/operator-binary/src/controller/build/resource/statefulset.rs

@@ -26,7 +26,9 @@ use stackable_operator::{
     product_logging,
     v2::{
         builder::pod::container::{EnvVarName, EnvVarSet, new_container_builder},
-        product_logging::framework::{ValidatedContainerLogConfigChoice, vector_container},
+        product_logging::framework::{
+            STACKABLE_LOG_DIR, ValidatedContainerLogConfigChoice, vector_container,
+        },
         types::{
             kubernetes::{ContainerName, VolumeName},
             operator::RoleGroupName,
@@ -40,7 +42,7 @@ use crate::{
         build::{
             graceful_shutdown::{self, add_graceful_shutdown_config},
             kerberos::{self, add_kerberos_pod_config},
-            properties::product_logging::{MAX_HBASE_LOG_FILES_SIZE, STACKABLE_LOG_DIR},
+            properties::product_logging::MAX_HBASE_LOG_FILES_SIZE,
         },
     },
     crd::{CONFIG_DIR_NAME, HbaseRole, LISTENER_VOLUME_DIR, LISTENER_VOLUME_NAME},