chore: remove left over product config references

Author: maltesander

docs/modules/hdfs/pages/reference/environment-variables.adoc

@@ -33,32 +33,6 @@ docker run \
 oci.stackable.tech/sdp/hdfs-operator:0.0.0-dev
 ----
 
-== PRODUCT_CONFIG
-
-*Default value*: `/etc/stackable/hdfs-operator/config-spec/properties.yaml`
-
-*Required*: false
-
-*Multiple values*: false
-
-[source]
-----
-export PRODUCT_CONFIG=/foo/bar/properties.yaml
-stackable-hdfs-operator run
-----
-
-or via docker:
-
-----
-docker run \
-    --name hdfs-operator \
-    --network host \
-    --env KUBECONFIG=/home/stackable/.kube/config \
-    --env PRODUCT_CONFIG=/my/product/config.yaml \
-    --mount type=bind,source="$HOME/.kube/config",target="/home/stackable/.kube/config" \
-    oci.stackable.tech/sdp/hdfs-operator:0.0.0-dev
-----
-
 == WATCH_NAMESPACE
 
 *Default value*: All namespaces

rust/operator-binary/src/controller/build/properties/core_site.rs

@@ -48,8 +48,7 @@ pub fn build(
         // The default (4096) hasn't changed since 2009.
         // Increase to 128k to allow for faster transfers.
         .add("io.file.buffer.size", "131072");
-    // Rack awareness topology provider, namenode only. Previously injected via
-    // the product-config `Configuration::compute_files`.
+    // Rack awareness topology provider, namenode only.
     if role == HdfsNodeRole::Name && cluster_config.rack_awareness.is_some() {
         core_site.add(
             "net.topology.node.switch.mapping.impl",

rust/operator-binary/src/controller/build/properties/security_properties.rs

@@ -1,8 +1,7 @@
 //! Builds the `security.properties` (JVM security) config file.
 //!
-//! The operator injects recommended JVM DNS cache TTLs (previously supplied via
-//! the product-config `properties.yaml`); user `configOverrides` are applied on
-//! top.
+//! The operator injects recommended JVM DNS cache TTLs.
+//! User `configOverrides` are applied on top.
 
 use std::collections::BTreeMap;
 

rust/operator-binary/src/controller/validate.rs

@@ -1,11 +1,9 @@
 //! The validate step in the HdfsCluster controller.
 //!
-//! Synchronously merges and validates the cluster spec into the typed
-//! [`ValidatedCluster`], consumed by `controller::build::*`. This replaces the
-//! product-config `transform_all_roles_to_config` /
-//! `validate_all_roles_and_groups_config` steps: config fragments are merged and
-//! validated via [`HdfsNodeRole::merged_config`], and the per-file
-//! `configOverrides` / `envOverrides` are merged here (role group wins).
+//! Synchronously merges and validates the cluster spec into the typed [`ValidatedCluster`]
+//! consumed by `controller::build::*`. Config fragments are merged and validated via
+//! [`HdfsNodeRole::merged_config`], and the per-file `configOverrides` / `envOverrides`
+//! are merged here (role group wins).
 
 use std::{collections::BTreeMap, str::FromStr};
 
@@ -85,8 +83,7 @@ pub fn validate_cluster(
                 .merged_config(hdfs, &role_group_name)
                 .context(FailedToResolveConfigSnafu)?;
 
-            // Rack awareness topology labels, namenode only. Previously injected
-            // via the product-config `Configuration::compute_env`.
+            // Rack awareness topology labels, namenode only.
             if hdfs_role == HdfsNodeRole::Name {
                 if let Some(rack_awareness) = hdfs.rackawareness_config() {
                     env_overrides.insert("TOPOLOGY_LABELS".to_string(), rack_awareness);
@@ -127,8 +124,7 @@ pub fn validate_cluster(
 }
 
 /// Merges the role-level and role-group-level `configOverrides` and `envOverrides`
-/// for every role group of a role (the role group wins). Replaces the
-/// product-config `transform_all_roles_to_config` step.
+/// for every role group of a role (the role group wins).
 fn collect_role_group_overrides<C>(
     role: Option<&Role<C, v1alpha1::HdfsConfigOverrides, GenericRoleConfig, JavaCommonConfig>>,
 ) -> Vec<(

rust/operator-binary/src/service.rs

@@ -19,9 +19,6 @@ pub enum Error {
     #[snafu(display("failed to build prometheus label"))]
     BuildPrometheusLabel { source: LabelError },
 
-    #[snafu(display("failed to build role-group selector label"))]
-    BuildRoleGroupSelectorLabel { source: LabelError },
-
     #[snafu(display("failed to build object meta data"))]
     ObjectMeta {
         source: stackable_operator::builder::meta::Error,