chore: use indoc for unit tests

Author: maltesander

rust/operator-binary/src/controller/build/properties/hadoop_policy.rs

@@ -14,6 +14,8 @@ pub fn build(overrides: KeyValueConfigOverrides) -> String {
 
 #[cfg(test)]
 mod tests {
+    use indoc::indoc;
+
     use super::*;
     use crate::controller::build::properties::test_support::EMPTY_HADOOP_XML;
 
@@ -26,15 +28,14 @@ mod tests {
     fn overrides_are_rendered_as_properties() {
         assert_eq!(
             build([("security.client.protocol.acl", "*")].into()),
-            concat!(
-                "<?xml version=\"1.0\"?>\n",
-                "<configuration>\n",
-                "  <property>\n",
-                "    <name>security.client.protocol.acl</name>\n",
-                "    <value>*</value>\n",
-                "  </property>\n",
-                "</configuration>"
-            )
+            indoc! {r#"
+                <?xml version="1.0"?>
+                <configuration>
+                  <property>
+                    <name>security.client.protocol.acl</name>
+                    <value>*</value>
+                  </property>
+                </configuration>"#}
         );
     }
 }

rust/operator-binary/src/controller/build/properties/mod.rs

@@ -72,18 +72,18 @@ mod tests {
 
 #[cfg(test)]
 pub(crate) mod test_support {
+    use indoc::indoc;
     use stackable_operator::{
         commons::networking::DomainName, utils::cluster_info::KubernetesClusterInfo,
     };
 
     use crate::{controller::ValidatedCluster, test_support::deserialize_and_validate_cluster};
 
     /// The rendered output of an empty Hadoop-XML configuration (no entries).
-    pub const EMPTY_HADOOP_XML: &str = concat!(
-        "<?xml version=\"1.0\"?>\n",
-        "<configuration>\n",
-        "</configuration>"
-    );
+    pub const EMPTY_HADOOP_XML: &str = indoc! {r#"
+        <?xml version="1.0"?>
+        <configuration>
+        </configuration>"#};
 
     /// A minimal three-role HdfsCluster used to drive the per-file builder tests.
     pub const MINIMAL_HDFS_YAML: &str = r#"

rust/operator-binary/src/controller/build/properties/security_properties.rs

@@ -29,29 +29,41 @@ pub fn build(overrides: KeyValueConfigOverrides) -> Result<String, PropertiesWri
 
 #[cfg(test)]
 mod tests {
+    use indoc::indoc;
+
     use super::*;
 
     #[test]
     fn injects_recommended_dns_cache_ttls() {
         assert_eq!(
             build(KeyValueConfigOverrides::default()).unwrap(),
-            "networkaddress.cache.negative.ttl=0\nnetworkaddress.cache.ttl=30\n"
+            indoc! {"
+                networkaddress.cache.negative.ttl=0
+                networkaddress.cache.ttl=30
+            "}
         );
     }
 
     #[test]
     fn user_overrides_win_over_injected_defaults() {
         assert_eq!(
             build([("networkaddress.cache.ttl", "60")].into()).unwrap(),
-            "networkaddress.cache.negative.ttl=0\nnetworkaddress.cache.ttl=60\n"
+            indoc! {"
+                networkaddress.cache.negative.ttl=0
+                networkaddress.cache.ttl=60
+            "}
         );
     }
 
     #[test]
     fn extra_overrides_are_appended() {
         assert_eq!(
             build([("foo.bar", "baz")].into()).unwrap(),
-            "foo.bar=baz\nnetworkaddress.cache.negative.ttl=0\nnetworkaddress.cache.ttl=30\n"
+            indoc! {"
+                foo.bar=baz
+                networkaddress.cache.negative.ttl=0
+                networkaddress.cache.ttl=30
+            "}
         );
     }
 }