derive the version label in tests from the operator version

Author: adwk67

rust/operator-binary/src/controller/build/resource/rbac.rs

@@ -48,7 +48,7 @@ mod tests {
     use super::*;
     use crate::{
         controller::build::properties::test_support::MINIMAL_HDFS_YAML,
-        test_support::deserialize_and_validate_cluster,
+        test_support::{app_version_label, deserialize_and_validate_cluster},
     };
 
     /// The cluster name is deliberately different from the product name (`hdfs`) so that
@@ -73,7 +73,7 @@ mod tests {
                         "app.kubernetes.io/managed-by": "hdfs.stackable.tech_hdfs-operator-hdfs-controller",
                         "app.kubernetes.io/name": "hdfs",
                         "app.kubernetes.io/role-group": "none",
-                        "app.kubernetes.io/version": "3.4.0-stackable0.0.0-dev",
+                        "app.kubernetes.io/version": app_version_label("3.4.0"),
                         "stackable.tech/vendor": "Stackable"
                     },
                     "name": "my-hdfs-serviceaccount",
@@ -108,7 +108,7 @@ mod tests {
                         "app.kubernetes.io/managed-by": "hdfs.stackable.tech_hdfs-operator-hdfs-controller",
                         "app.kubernetes.io/name": "hdfs",
                         "app.kubernetes.io/role-group": "none",
-                        "app.kubernetes.io/version": "3.4.0-stackable0.0.0-dev",
+                        "app.kubernetes.io/version": app_version_label("3.4.0"),
                         "stackable.tech/vendor": "Stackable"
                     },
                     "name": "my-hdfs-rolebinding",

rust/operator-binary/src/controller/build/resource/service.rs

@@ -139,6 +139,7 @@ mod tests {
     use super::*;
     use crate::{
         controller::build::properties::test_support::validated_cluster, crd::HdfsNodeRole,
+        test_support::app_version_label,
     };
 
     #[test]
@@ -170,7 +171,7 @@ mod tests {
                         "app.kubernetes.io/managed-by": "hdfs.stackable.tech_hdfs-operator-hdfs-controller",
                         "app.kubernetes.io/name": "hdfs",
                         "app.kubernetes.io/role-group": "default",
-                        "app.kubernetes.io/version": "3.4.0-stackable0.0.0-dev",
+                        "app.kubernetes.io/version": app_version_label("3.4.0"),
                         "prometheus.io/scrape": "true",
                         "stackable.tech/vendor": "Stackable"
                     },

rust/operator-binary/src/test_support.rs

@@ -7,6 +7,18 @@ use crate::{
     crd::{AnyNodeConfig, DataNodeConfig, HdfsNodeRole, v1alpha1},
 };
 
+/// The expected `app.kubernetes.io/version` label value for the given product version.
+///
+/// The `-stackable` suffix carries the operator's own version, which is `0.0.0-dev` on main
+/// but rewritten by the release process — so tests must derive it rather than hardcode it,
+/// or they fail on release branches.
+pub fn app_version_label(product_version: &str) -> String {
+    format!(
+        "{product_version}-stackable{}",
+        crate::built_info::PKG_VERSION
+    )
+}
+
 pub fn deserialize_cluster(spec: &str) -> v1alpha1::HdfsCluster {
     let deserializer = serde_yaml::Deserializer::from_str(spec);
     serde_yaml::with::singleton_map_recursive::deserialize(deserializer).expect("")