chore: bump Rust edition to 2024 and apply cargo fix + clippy updates

Run `cargo fix --edition`:

- Fix Rust 2024 temporary drop order change in tail expression by adding a trailing semicolon to the controller match block in hdfs_clusterrolebinding_nodes_controller.rs
- Add use<> (auto refactor by cargo fix)
Clippy refactor:
- Simplify nested conditions

Author: Saul-STFC

Cargo.nix

@@ -6,7 +6,7 @@ resolver = "2"
 version = "0.0.0-dev"
 authors = ["Stackable GmbH <info@stackable.tech>"]
 license = "OSL-3.0"
-edition = "2021"
+edition = "2024"
 repository = "https://github.com/stackabletech/hdfs-operator"
 
 [workspace.dependencies]

Cargo.toml

@@ -617,7 +617,7 @@ impl v1alpha1::HdfsCluster {
             (
                 Vec<PropertyNameKind>,
                 Role<
-                    impl Configuration<Configurable = v1alpha1::HdfsCluster>,
+                    impl Configuration<Configurable = v1alpha1::HdfsCluster> + use<>,
                     v1alpha1::HdfsConfigOverrides,
                     GenericRoleConfig,
                     JavaCommonConfig,
@@ -1412,10 +1412,10 @@ impl Configuration for NameNodeConfigFragment {
         // If rack awareness is configured, insert the labels into an env var to configure
         // the topology-provider and add the artifact to the classpath.
         // This is only needed on namenodes.
-        if role_name == HdfsNodeRole::Name.to_string() {
-            if let Some(awareness_config) = resource.rackawareness_config() {
-                result.insert("TOPOLOGY_LABELS".to_string(), Some(awareness_config));
-            }
+        if role_name == HdfsNodeRole::Name.to_string()
+            && let Some(awareness_config) = resource.rackawareness_config()
+        {
+            result.insert("TOPOLOGY_LABELS".to_string(), Some(awareness_config));
         }
         Ok(result)
     }
@@ -1440,13 +1440,14 @@ impl Configuration for NameNodeConfigFragment {
                 DFS_REPLICATION.to_string(),
                 Some(resource.spec.cluster_config.dfs_replication.to_string()),
             );
-        } else if file == CORE_SITE_XML && role_name == HdfsNodeRole::Name.to_string() {
-            if let Some(_awareness_config) = resource.rackawareness_config() {
-                config.insert(
-                    "net.topology.node.switch.mapping.impl".to_string(),
-                    Some("tech.stackable.hadoop.StackableTopologyProvider".to_string()),
-                );
-            }
+        } else if file == CORE_SITE_XML
+            && role_name == HdfsNodeRole::Name.to_string()
+            && let Some(_awareness_config) = resource.rackawareness_config()
+        {
+            config.insert(
+                "net.topology.node.switch.mapping.impl".to_string(),
+                Some("tech.stackable.hadoop.StackableTopologyProvider".to_string()),
+            );
         }
 
         Ok(config)

rust/operator-binary/src/crd/mod.rs

@@ -105,5 +105,5 @@ pub async fn reconcile(
             &patch
         ),
         Err(e) => error!("{}", e),
-    }
+    };
 }

rust/operator-binary/src/hdfs_clusterrolebinding_nodes_controller.rs

@@ -37,7 +37,7 @@ pub async fn create_webhook_server(
         field_manager: FIELD_MANAGER.to_owned(),
     };
 
-    let (conversion_webhook, _initial_reconcile_rx) =
+    let (conversion_webhook, _) =
         ConversionWebhook::new(crds_and_handlers, client, conversion_webhook_options);
 
     let webhook_server_options = WebhookServerOptions {