Skip to content

refactor: Introduce build aggregator#801

Merged
adwk67 merged 4 commits into
mainfrom
feat/smooth-operator/introduce-builder
Jul 21, 2026
Merged

refactor: Introduce build aggregator#801
adwk67 merged 4 commits into
mainfrom
feat/smooth-operator/introduce-builder

Conversation

@maltesander

@maltesander maltesander commented Jul 10, 2026

Copy link
Copy Markdown
Member

Description

Part of stackabletech/issues#864.

  • Plain KubernetesResources; fallible build(cluster, sa_name) reusing existing builders
  • Reconcile rewritten to a build-then-apply loop (StatefulSets last)
  • Built-SA name

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@maltesander maltesander self-assigned this Jul 10, 2026
@maltesander maltesander mentioned this pull request Jul 10, 2026
Closed
12 tasks
adwk67
adwk67 reviewed Jul 14, 2026
View reviewed changes

@adwk67 adwk67 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but we should look at the labelling mechanism.

Comment thread rust/operator-binary/src/controller/build/mod.rs
adwk67
adwk67 reviewed Jul 14, 2026
View reviewed changes

@adwk67 adwk67 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this fit into the dereference/validate/build/apply paradigm?
let discovery_cm = build_discovery_config_map
That requires a client and can only be done once the listeners are deployed. I guess no way around that?

siegfriedweber

This comment was marked as off-topic.

Sign in to view

@siegfriedweber

siegfriedweber commented Jul 14, 2026

Copy link
Copy Markdown
Member

How does this fit into the dereference/validate/build/apply paradigm? let discovery_cm = build_discovery_config_map That requires a client and can only be done once the listeners are deployed. I guess no way around that?

The build_discovery_config_map should return Option<ConfigMap>. If the Listener status is not set, None is returned. The operator should watch the Listener. When its status is set, reconcile is called and the discovery ConfigMap is eventually created.

@adwk67
adwk67 added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit abb40b2 Jul 21, 2026
18 checks passed
@adwk67
adwk67 deleted the feat/smooth-operator/introduce-builder branch July 21, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siegfriedweber siegfriedweber siegfriedweber left review comments
@adwk67 adwk67 adwk67 approved these changes

Assignees

@maltesander maltesander

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maltesander @siegfriedweber @adwk67