Skip to content

Commit 00375d1

Browse files
committed
more consistent wording
1 parent 1eddee0 commit 00375d1

3 files changed

Lines changed: 9 additions & 10 deletions

File tree

rust/operator-binary/src/controller.rs

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -520,15 +520,14 @@ pub async fn reconcile_hive(
520520
let mut discovery_hash = FnvHasher::with_key(0);
521521

522522
if let Some(HiveMetastoreRoleConfig { listener_class, .. }) = role_config {
523-
let group_listener: Listener =
523+
let role_listener: Listener =
524524
build_role_listener(hive, &resolved_product_image, &hive_role, listener_class)
525525
.context(ListenerConfigurationSnafu)?;
526-
let listener = cluster_resources
527-
.add(client, group_listener)
528-
.await
529-
.context(ApplyGroupListenerSnafu {
526+
let listener = cluster_resources.add(client, role_listener).await.context(
527+
ApplyGroupListenerSnafu {
530528
role: hive_role.to_string(),
531-
})?;
529+
},
530+
)?;
532531

533532
for discovery_cm in discovery::build_discovery_configmaps(
534533
hive,
@@ -961,7 +960,7 @@ fn build_metastore_rolegroup_statefulset(
961960
.build();
962961

963962
let pvc = ListenerOperatorVolumeSourceBuilder::new(
964-
&ListenerReference::ListenerName(hive.group_listener_name(hive_role)),
963+
&ListenerReference::ListenerName(hive.role_listener_name(hive_role)),
965964
&unversioned_recommended_labels,
966965
)
967966
.context(BuildListenerVolumeSnafu)?

rust/operator-binary/src/crd/mod.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -240,9 +240,9 @@ impl v1alpha1::HiveCluster {
240240
})
241241
}
242242

243-
/// The name of the group-listener provided for a specific role.
243+
/// The name of the role-listener provided for a specific role.
244244
/// returns a name `<cluster>-<role>`
245-
pub fn group_listener_name(&self, hive_role: &HiveRole) -> String {
245+
pub fn role_listener_name(&self, hive_role: &HiveRole) -> String {
246246
format!("{name}-{role}", name = self.name_any(), role = hive_role)
247247
}
248248

rust/operator-binary/src/listener.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ pub fn build_role_listener(
7777
) -> Result<Listener, Error> {
7878
let metadata = ObjectMetaBuilder::new()
7979
.name_and_namespace(hive)
80-
.name(hive.group_listener_name(hive_role))
80+
.name(hive.role_listener_name(hive_role))
8181
.ownerreference_from_resource(hive, None, Some(true))
8282
.context(ObjectMissingMetadataForOwnerRefSnafu)?
8383
.with_recommended_labels(build_recommended_labels(

0 commit comments

Comments
 (0)