Skip to content

Commit 1788490

Browse files
committed
pass dereferenced fields through to validation
1 parent 268ec15 commit 1788490

2 files changed

Lines changed: 14 additions & 4 deletions

File tree

rust/operator-binary/src/controller.rs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -335,6 +335,8 @@ pub struct ValidatedCluster {
335335
pub role_groups: BTreeMap<String, ValidatedRoleGroupConfig>,
336336
pub role_config: Option<ValidatedRoleConfig>,
337337
pub metadata_database_connection_details: JdbcDatabaseConnectionDetails,
338+
pub s3_connection_spec: Option<s3::v1alpha1::ConnectionSpec>,
339+
pub hive_opa_config: Option<HiveOpaConfig>,
338340
}
339341

340342
pub async fn reconcile_hive(
@@ -358,6 +360,8 @@ pub async fn reconcile_hive(
358360
hive,
359361
&ctx.operator_environment.image_repository,
360362
&ctx.product_config,
363+
dereferenced.s3_connection_spec,
364+
dereferenced.hive_opa_config,
361365
)
362366
.context(ValidateSnafu)?;
363367

@@ -410,10 +414,10 @@ pub async fn reconcile_hive(
410414
&rolegroup,
411415
&validated_rg_config.product_config_properties,
412416
&validated.metadata_database_connection_details,
413-
dereferenced.s3_connection_spec.as_ref(),
417+
validated.s3_connection_spec.as_ref(),
414418
&validated_rg_config.merged_config,
415419
&client.kubernetes_cluster_info,
416-
dereferenced.hive_opa_config.as_ref(),
420+
validated.hive_opa_config.as_ref(),
417421
)?;
418422
let rg_statefulset = build_metastore_rolegroup_statefulset(
419423
hive,
@@ -422,10 +426,10 @@ pub async fn reconcile_hive(
422426
&rolegroup,
423427
&validated_rg_config.product_config_properties,
424428
&validated.metadata_database_connection_details,
425-
dereferenced.s3_connection_spec.as_ref(),
429+
validated.s3_connection_spec.as_ref(),
426430
&validated_rg_config.merged_config,
427431
&rbac_sa.name_any(),
428-
dereferenced.hive_opa_config.as_ref(),
432+
validated.hive_opa_config.as_ref(),
429433
)?;
430434

431435
cluster_resources

rust/operator-binary/src/controller/validate.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,13 @@ use product_config::{ProductConfigManager, types::PropertyNameKind};
77
use snafu::{OptionExt, ResultExt, Snafu};
88
use stackable_operator::{
99
commons::product_image_selection,
10+
crd::s3,
1011
product_config_utils::{transform_all_roles_to_config, validate_all_roles_and_groups_config},
1112
role_utils::GenericRoleConfig,
1213
};
1314

1415
use crate::{
16+
config::opa::HiveOpaConfig,
1517
controller::{CONTAINER_IMAGE_BASE_NAME, ValidatedCluster},
1618
crd::{
1719
HIVE_SITE_XML, HiveRole, JVM_SECURITY_PROPERTIES_FILE, MetaStoreConfig,
@@ -66,6 +68,8 @@ pub fn validate_cluster(
6668
hive: &v1alpha1::HiveCluster,
6769
image_repository: &str,
6870
product_config_manager: &ProductConfigManager,
71+
s3_connection_spec: Option<s3::v1alpha1::ConnectionSpec>,
72+
hive_opa_config: Option<HiveOpaConfig>,
6973
) -> Result<ValidatedCluster, Error> {
7074
let resolved_product_image = hive
7175
.spec
@@ -155,5 +159,7 @@ pub fn validate_cluster(
155159
role_groups: group_configs,
156160
role_config,
157161
metadata_database_connection_details,
162+
s3_connection_spec,
163+
hive_opa_config,
158164
})
159165
}

0 commit comments

Comments
 (0)