chore: switch to ResourceName metrics service helper

Author: maltesander

rust/operator-binary/src/controller/build/resource/service.rs

@@ -47,7 +47,10 @@ pub fn build_rolegroup_metrics_service(
     Service {
         metadata: cluster
             .object_meta(
-                metrics_service_name(cluster, role_group_name),
+                cluster
+                    .resource_names(role_group_name)
+                    .metrics_service_name()
+                    .to_string(),
                 role_group_name,
             )
             .with_labels(prometheus_labels())
@@ -66,18 +69,6 @@ pub fn build_rolegroup_metrics_service(
     }
 }
 
-/// The metrics [`Service`] name, `<cluster>-<role>-<rolegroup>-metrics`.
-///
-/// [`ResourceNames`](stackable_operator::v2::role_group_utils::ResourceNames) has no metrics
-/// service helper, so the `-metrics` suffix is appended to the qualified role-group name (which is
-/// also the StatefulSet name).
-fn metrics_service_name(cluster: &ValidatedCluster, role_group_name: &RoleGroupName) -> String {
-    format!(
-        "{qualified}-metrics",
-        qualified = cluster.resource_names(role_group_name).stateful_set_name()
-    )
-}
-
 fn metrics_ports() -> Vec<ServicePort> {
     vec![ServicePort {
         name: Some(METRICS_PORT_NAME.to_string()),