Test for metrics port, rename metrics svc name function

Author: Maleware

rust/operator-binary/src/controller.rs

@@ -98,7 +98,7 @@ use crate::{
         STACKABLE_LOG_DIR_NAME,
         v1alpha1::{self, HiveMetastoreRoleConfig},
     },
-    discovery::{self, build_headless_listener_service_name},
+    discovery::{self, build_headless_role_group_metrics_service_name},
     kerberos::{
         self, add_kerberos_pod_config, kerberos_config_properties,
         kerberos_container_start_commands,
@@ -769,7 +769,7 @@ fn build_rolegroup_service(
     Ok(Service {
         metadata: ObjectMetaBuilder::new()
             .name_and_namespace(hive)
-            .name(build_headless_listener_service_name(
+            .name(build_headless_role_group_metrics_service_name(
                 rolegroup.object_name(),
             ))
             .ownerreference_from_resource(hive, None, Some(true))
@@ -1145,7 +1145,7 @@ fn build_metastore_rolegroup_statefulset(
                 ),
                 ..LabelSelector::default()
             },
-            service_name: Some(build_headless_listener_service_name(
+            service_name: Some(build_headless_role_group_metrics_service_name(
                 rolegroup_ref.object_name(),
             )),
             template: pod_template,

rust/operator-binary/src/discovery.rs

@@ -146,6 +146,6 @@ fn build_listener_connection_string(
     Ok(conn_str)
 }
 
-pub fn build_headless_listener_service_name(name: String) -> String {
+pub fn build_headless_role_group_metrics_service_name(name: String) -> String {
     format!("{name}-metrics", name = name)
 }

tests/templates/kuttl/external-access/20-assert.yaml

@@ -30,3 +30,10 @@ metadata:
   name: test-hive-metastore
 spec:
   type: ClusterIP # cluster-internal
+---
+apiVersion: v1
+kind: Service
+metadata:
+  name: test-hive-metastore-default-metrics 
+spec:
+  type: ClusterIP # exposed metrics