Skip to content

Commit 38e162b

Browse files
committed
Clarify on generic
1 parent b1486d0 commit 38e162b

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

rust/operator-binary/src/crd/databases.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,9 @@ pub enum MetadataDatabaseConnection {
2727
// Docs are on the struct
2828
Derby(DerbyConnection),
2929
// We don't support generic (yet?), as we need to tell the metastore the `--dbtype` on startup,
30-
// which is not known for generic connection.
31-
// Generic(GenericJdbcDatabaseConnection),
30+
// which is not known for generic connection. We could e.g. create a new struct with
31+
// #[serde(flatten)] of the GenericJdbcDatabaseConnection and an additional field
32+
// `metastoreDbType` (or similar).
3233
}
3334

3435
impl Deref for MetadataDatabaseConnection {

0 commit comments

Comments
 (0)