Apply suggestions from code review

Co-authored-by: maltesander <malte.sander.it@gmail.com>
Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>

Author: maltesander

rust/operator-binary/src/controller.rs

@@ -131,7 +131,6 @@ pub enum Error {
     },
 
     #[snafu(display("internal operator failure"))]
-    InternalOperatorFailure { source: crate::crd::Error },
 
     #[snafu(display("failed to apply PodDisruptionBudget"))]
     ApplyPdb {
@@ -329,9 +328,6 @@ impl ValidatedCluster {
     }
 
     /// Whether Kerberos is enabled for this cluster (a Kerberos `SecretClass` was configured).
-    ///
-    /// Mirrors [`v1alpha1::HiveCluster::has_kerberos_enabled`], derived here from the validated
-    /// config so build steps don't have to re-read the raw cluster.
     pub fn has_kerberos_enabled(&self) -> bool {
         self.cluster_config.kerberos_secret_class.is_some()
     }

rust/operator-binary/src/controller/build/opa.rs

@@ -127,6 +127,6 @@ impl HiveOpaConfig {
     pub fn tls_ca_cert_mount_path(&self) -> Option<String> {
         self.tls_secret_class
             .as_ref()
-            .map(|_| format!("/stackable/secrets/{}", &*OPA_TLS_VOLUME_NAME))
+            .map(|_| format!("/stackable/secrets/{}", *OPA_TLS_VOLUME_NAME))
     }
 }

rust/operator-binary/src/controller/build/resource/listener.rs

@@ -11,7 +11,7 @@ use crate::{
 
 #[derive(Snafu, Debug)]
 pub enum Error {
-    #[snafu(display("{role} listener has no adress"))]
+    #[snafu(display("{role} listener has no address"))]
     RoleListenerHasNoAddress { role: String },
     #[snafu(display("could not find port [{port_name}] for rolegroup listener {role}"))]
     NoServicePort { port_name: String, role: String },

rust/operator-binary/src/controller/validate.rs

@@ -94,10 +94,6 @@ pub enum Error {
 }
 
 /// Validated logging configuration for the Hive metastore and (optional) Vector container.
-///
-/// Produced up-front by [`validate_logging`] (mirroring the opensearch-operator) so that an
-/// invalid custom log ConfigMap name or a missing Vector aggregator discovery ConfigMap name
-/// fails reconciliation during validation rather than at resource-build time.
 #[derive(Clone, Debug, PartialEq, Eq)]
 pub struct ValidatedLogging {
     pub hive_container: ValidatedContainerLogConfigChoice,

rust/operator-binary/src/crd/mod.rs

@@ -2,10 +2,6 @@ use std::str::FromStr;
 
 use databases::MetadataDatabaseConnection;
 /// Re-export of the shared product-logging spec data types (test-only).
-///
-/// These are plain logging *data* types (also consumed by the `stackable_operator::v2` logging
-/// framework). Re-exporting them through `crate::crd` lets the logging validation tests reference
-/// them without importing the v1 `product_logging` module by its fully-qualified path.
 #[cfg(test)]
 pub use product_logging::spec::{
     ConfigMapLogConfig, ContainerLogConfig, ContainerLogConfigChoice, CustomContainerLogConfig,