fix: drop hardcoded hive-site.xml, remove duplicated hive port

Author: maltesander

rust/operator-binary/src/controller/build/command.rs

@@ -20,6 +20,7 @@ pub fn build_container_command_args(
 ) -> Vec<String> {
     let log4j2_properties = ConfigFileName::Log4j2;
     let core_site = ConfigFileName::CoreSite;
+    let hive_site = ConfigFileName::HiveSite;
     let mut args = vec![
         // copy config files to a writeable empty folder in order to set s3 access and secret keys
         format!("echo copying {STACKABLE_CONFIG_MOUNT_DIR} to {STACKABLE_CONFIG_DIR}"),
@@ -36,7 +37,7 @@ pub fn build_container_command_args(
             "if test -f {STACKABLE_CONFIG_DIR}/{core_site}; then config-utils template {STACKABLE_CONFIG_DIR}/{core_site}; fi"
         ),
         format!(
-            "if test -f {STACKABLE_CONFIG_DIR}/hive-site.xml; then config-utils template {STACKABLE_CONFIG_DIR}/hive-site.xml; fi"
+            "if test -f {STACKABLE_CONFIG_DIR}/{hive_site}; then config-utils template {STACKABLE_CONFIG_DIR}/{hive_site}; fi"
         ),
         // Copy system truststore to stackable truststore
         format!(

rust/operator-binary/src/controller/build/properties/hive_site.rs

@@ -4,13 +4,15 @@ use std::collections::BTreeMap;
 use snafu::{ResultExt, Snafu};
 use stackable_operator::{crd::s3, k8s_openapi::api::core::v1::EnvVar};
 
-use crate::controller::{
-    ValidatedClusterConfig, ValidatedMetaStoreConfig, build::opa::build_opa_hive_site_config,
+use crate::{
+    controller::{
+        ValidatedClusterConfig, ValidatedMetaStoreConfig, build::opa::build_opa_hive_site_config,
+    },
+    crd::HIVE_PORT,
 };
 
 const DEFAULT_WAREHOUSE_DIR: &str = "/stackable/warehouse";
 const HIVE_METASTORE_PORT: &str = "hive.metastore.port";
-const DEFAULT_HIVE_METASTORE_PORT: &str = "9083";
 
 // Metastore property keys.
 const CONNECTION_DRIVER_NAME: &str = "javax.jdo.option.ConnectionDriverName";
@@ -49,10 +51,7 @@ pub fn build(
     let mut data: BTreeMap<String, String> = BTreeMap::new();
 
     // 1. Defaults.
-    data.insert(
-        HIVE_METASTORE_PORT.to_string(),
-        DEFAULT_HIVE_METASTORE_PORT.to_string(),
-    );
+    data.insert(HIVE_METASTORE_PORT.to_string(), HIVE_PORT.to_string());
 
     // 2. Automatic / operator-injected.
     data.insert(