Skip to content

Commit 705811f

Browse files
Apply minor review changes
Co-authored-by: Malte Sander <contact@maltesander.com>
1 parent d8fde0b commit 705811f

3 files changed

Lines changed: 4 additions & 8 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ All notable changes to this project will be documented in this file.
1010
- Use `--file-log-max-files` (or `FILE_LOG_MAX_FILES`) to limit the number of log files kept.
1111
- Use `--file-log-rotation-period` (or `FILE_LOG_ROTATION_PERIOD`) to configure the frequency of rotation.
1212
- Use `--console-log-format` (or `CONSOLE_LOG_FORMAT`) to set the format to `plain` (default) or `json`.
13-
- BREAKING: Added Listener support for Hive ([#605])
13+
- BREAKING: Add Listener support for Hive ([#605])
1414

1515
### Changed
1616

docs/modules/hive/pages/usage-guide/listenerclass.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
:description: Configure the Hive service exposure with listener classes: cluster-internal, external-unstable or external-stable
33

44
Apache Hive offers an API.
5-
The operator deploys a xref:listener-operator:listener.adoc[Listener] for the Nodes pod.
5+
The operator deploys a xref:listener-operator:listener.adoc[Listener] for the Metastore pods.
66

7-
The listener defaults to only being accessible from within the Kubernetes cluster, but this can be changed by setting `.spec.nodes.roleConfig.listenerClass`:
7+
The listener defaults to only being accessible from within the Kubernetes cluster, but this can be changed by setting `.spec.metastore.roleConfig.listenerClass`:
88

99
[source,yaml]
1010
----

rust/operator-binary/src/controller.rs

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -371,11 +371,7 @@ pub async fn reconcile_hive(
371371
.spec
372372
.image
373373
.resolve(DOCKER_IMAGE_BASE_NAME, crate::built_info::PKG_VERSION);
374-
let role: &stackable_operator::role_utils::Role<
375-
MetaStoreConfigFragment,
376-
v1alpha1::HiveMetastoreRoleConfig,
377-
stackable_operator::role_utils::JavaCommonConfig,
378-
> = hive.spec.metastore.as_ref().context(NoMetaStoreRoleSnafu)?;
374+
let role = hive.spec.metastore.as_ref().context(NoMetaStoreRoleSnafu)?;
379375
let hive_role = HiveRole::MetaStore;
380376

381377
let s3_connection_spec: Option<s3::v1alpha1::ConnectionSpec> =

0 commit comments

Comments
 (0)