chore: Split the clusterroles between operator and product

Author: NickLarsenNZ

…/helm/hive-operator/templates/roles.yaml …ator/templates/clusterrole-operator.yamldeploy/helm/hive-operator/templates/roles.yaml renamed to deploy/helm/hive-operator/templates/clusterrole-operator.yaml deploy/helm/hive-operator/templates/roles.yaml renamed to deploy/helm/hive-operator/templates/clusterrole-operator.yaml

@@ -146,22 +146,3 @@ rules:
       - get
       - list
       - patch
----
-apiVersion: rbac.authorization.k8s.io/v1
-kind: ClusterRole
-metadata:
-  name: {{ include "operator.name" . }}-clusterrole
-  labels:
-  {{- include "operator.labels" . | nindent 4 }}
-rules:
-{{ if .Capabilities.APIVersions.Has "security.openshift.io/v1" }}
-  # Required on OpenShift to allow the Hive pods to run as a non-root user.
-  - apiGroups:
-      - security.openshift.io
-    resources:
-      - securitycontextconstraints
-    resourceNames:
-      - nonroot-v2
-    verbs:
-      - use
-{{ end }}

deploy/helm/hive-operator/templates/clusterrole-product.yaml

@@ -0,0 +1,21 @@
+---
+# Product ClusterRole: bound (via per HiveCluster RoleBinding) to the ServiceAccount that Hive
+# workload pods (metastore) run as.
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
+metadata:
+  name: {{ include "operator.name" . }}-clusterrole
+  labels:
+  {{- include "operator.labels" . | nindent 4 }}
+rules:
+{{ if .Capabilities.APIVersions.Has "security.openshift.io/v1" }}
+  # Required on OpenShift to allow the Hive pods to run as a non-root user.
+  - apiGroups:
+      - security.openshift.io
+    resources:
+      - securitycontextconstraints
+    resourceNames:
+      - nonroot-v2
+    verbs:
+      - use
+{{ end }}