fix: use build structure for pdb instead of mutating.

Author: maltesander

rust/operator-binary/src/controller.rs

@@ -46,7 +46,7 @@ use crate::{
         resource::{
             discovery,
             listener::build_role_listener,
-            pdb::add_pdbs,
+            pdb::build_pdb,
             service::{build_rolegroup_headless_service, build_rolegroup_metrics_service},
         },
     },
@@ -125,9 +125,9 @@ pub enum Error {
     #[snafu(display("internal operator failure"))]
     InternalOperatorFailure { source: crate::crd::Error },
 
-    #[snafu(display("failed to create PodDisruptionBudget"))]
-    FailedToCreatePdb {
-        source: crate::controller::build::resource::pdb::Error,
+    #[snafu(display("failed to apply PodDisruptionBudget"))]
+    ApplyPdb {
+        source: stackable_operator::cluster_resources::Error,
     },
 
     #[snafu(display("failed to get required Labels"))]
@@ -542,15 +542,12 @@ pub async fn reconcile_hive(
     let mut discovery_hash = FnvHasher::with_key(0);
 
     if let Some(role_config) = &validated_cluster.role_config {
-        add_pdbs(
-            &role_config.pdb,
-            &validated_cluster,
-            &HiveRole::MetaStore,
-            client,
-            &mut cluster_resources,
-        )
-        .await
-        .context(FailedToCreatePdbSnafu)?;
+        if let Some(pdb) = build_pdb(&role_config.pdb, &validated_cluster, &HiveRole::MetaStore) {
+            cluster_resources
+                .add(client, pdb)
+                .await
+                .context(ApplyPdbSnafu)?;
+        }
 
         let role_listener: Listener = build_role_listener(
             &validated_cluster,

rust/operator-binary/src/controller/build/resource/pdb.rs

@@ -1,32 +1,21 @@
-use snafu::{ResultExt, Snafu};
 use stackable_operator::{
-    client::Client, cluster_resources::ClusterResources, commons::pdb::PdbConfig,
-    kube::ResourceExt, v2::builder::pdb::pod_disruption_budget_builder_with_role,
+    commons::pdb::PdbConfig, k8s_openapi::api::policy::v1::PodDisruptionBudget,
+    v2::builder::pdb::pod_disruption_budget_builder_with_role,
 };
 
 use crate::{
     controller::{ValidatedCluster, controller_name, operator_name, product_name},
     crd::HiveRole,
 };
 
-#[derive(Snafu, Debug)]
-pub enum Error {
-    #[snafu(display("Cannot apply PodDisruptionBudget [{name}]"))]
-    ApplyPdb {
-        source: stackable_operator::cluster_resources::Error,
-        name: String,
-    },
-}
-
-pub async fn add_pdbs(
+/// Builds the [`PodDisruptionBudget`] for the given `role`, or `None` if PDBs are disabled.
+pub fn build_pdb(
     pdb: &PdbConfig,
     cluster: &ValidatedCluster,
     role: &HiveRole,
-    client: &Client,
-    cluster_resources: &mut ClusterResources<'_>,
-) -> Result<(), Error> {
+) -> Option<PodDisruptionBudget> {
     if !pdb.enabled {
-        return Ok(());
+        return None;
     }
     let max_unavailable = pdb.max_unavailable.unwrap_or(match role {
         HiveRole::MetaStore => max_unavailable_metastores(),
@@ -40,13 +29,8 @@ pub async fn add_pdbs(
     )
     .with_max_unavailable(max_unavailable)
     .build();
-    let pdb_name = pdb.name_any();
-    cluster_resources
-        .add(client, pdb)
-        .await
-        .with_context(|_| ApplyPdbSnafu { name: pdb_name })?;
 
-    Ok(())
+    Some(pdb)
 }
 
 fn max_unavailable_metastores() -> u16 {