replace parameter with constant

Author: adwk67

rust/operator-binary/src/controller.rs

@@ -117,7 +117,7 @@ use crate::{
 pub const HIVE_CONTROLLER_NAME: &str = "hivecluster";
 pub const HIVE_FULL_CONTROLLER_NAME: &str = concatcp!(HIVE_CONTROLLER_NAME, '.', OPERATOR_NAME);
 
-const CONTAINER_IMAGE_BASE_NAME: &str = "hive";
+pub const CONTAINER_IMAGE_BASE_NAME: &str = "hive";
 
 pub const MAX_HIVE_LOG_FILES_SIZE: MemoryQuantity = MemoryQuantity {
     value: 10.0,
@@ -356,7 +356,6 @@ pub async fn reconcile_hive(
 
     let validated = validate::validate_cluster(
         hive,
-        CONTAINER_IMAGE_BASE_NAME,
         &ctx.operator_environment.image_repository,
         crate::built_info::PKG_VERSION,
         &ctx.product_config,

rust/operator-binary/src/controller/validate.rs

@@ -12,7 +12,7 @@ use stackable_operator::{
 };
 
 use crate::{
-    controller::ValidatedHiveCluster,
+    controller::{CONTAINER_IMAGE_BASE_NAME, ValidatedHiveCluster},
     crd::{
         HIVE_SITE_XML, HiveRole, JVM_SECURITY_PROPERTIES_FILE, MetaStoreConfig,
         v1alpha1::{self, HiveMetastoreRoleConfig},
@@ -64,15 +64,14 @@ pub struct ValidatedRoleGroupConfig {
 
 pub fn validate_cluster(
     hive: &v1alpha1::HiveCluster,
-    image_base_name: &str,
     image_repository: &str,
     pkg_version: &str,
     product_config_manager: &ProductConfigManager,
 ) -> Result<ValidatedHiveCluster, Error> {
     let resolved_product_image = hive
         .spec
         .image
-        .resolve(image_base_name, image_repository, pkg_version)
+        .resolve(CONTAINER_IMAGE_BASE_NAME, image_repository, pkg_version)
         .context(ResolveProductImageSnafu)?;
 
     let role = hive.spec.metastore.as_ref().context(NoMetaStoreRoleSnafu)?;