Skip to content

Commit ec2224e

Browse files
committed
fix: bump stackable-operator dependency for non optional KeyValueConfigOverrides
1 parent 2cde378 commit ec2224e

5 files changed

Lines changed: 41 additions & 77 deletions

File tree

Cargo.lock

Lines changed: 17 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.nix

Lines changed: 17 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

extra/crds.yaml

Lines changed: 4 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -798,25 +798,15 @@ spec:
798798
properties:
799799
hive-site.xml:
800800
additionalProperties:
801-
nullable: true
802801
type: string
803802
default: {}
804-
description: |-
805-
Flat key-value overrides for `*.properties`, Hadoop XML, etc.
806-
807-
This is backwards-compatible with the existing flat key-value YAML format
808-
used by `HashMap<String, String>`.
803+
description: Flat key-value overrides for `*.properties`, Hadoop XML, etc.
809804
type: object
810805
security.properties:
811806
additionalProperties:
812-
nullable: true
813807
type: string
814808
default: {}
815-
description: |-
816-
Flat key-value overrides for `*.properties`, Hadoop XML, etc.
817-
818-
This is backwards-compatible with the existing flat key-value YAML format
819-
used by `HashMap<String, String>`.
809+
description: Flat key-value overrides for `*.properties`, Hadoop XML, etc.
820810
type: object
821811
type: object
822812
envOverrides:
@@ -1257,25 +1247,15 @@ spec:
12571247
properties:
12581248
hive-site.xml:
12591249
additionalProperties:
1260-
nullable: true
12611250
type: string
12621251
default: {}
1263-
description: |-
1264-
Flat key-value overrides for `*.properties`, Hadoop XML, etc.
1265-
1266-
This is backwards-compatible with the existing flat key-value YAML format
1267-
used by `HashMap<String, String>`.
1252+
description: Flat key-value overrides for `*.properties`, Hadoop XML, etc.
12681253
type: object
12691254
security.properties:
12701255
additionalProperties:
1271-
nullable: true
12721256
type: string
12731257
default: {}
1274-
description: |-
1275-
Flat key-value overrides for `*.properties`, Hadoop XML, etc.
1276-
1277-
This is backwards-compatible with the existing flat key-value YAML format
1278-
used by `HashMap<String, String>`.
1258+
description: Flat key-value overrides for `*.properties`, Hadoop XML, etc.
12791259
type: object
12801260
type: object
12811261
envOverrides:

rust/operator-binary/src/controller/build/config_map.rs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@ use stackable_operator::{
1212
use crate::{
1313
controller::{
1414
HiveRoleGroupConfig, ValidatedCluster,
15-
build::properties::{
16-
ConfigFileName, core_site, hive_site, logging, resolved_overrides, security_properties,
17-
},
15+
build::properties::{ConfigFileName, core_site, hive_site, logging, security_properties},
1816
build_recommended_labels,
1917
},
2018
crd::v1alpha1,
@@ -55,7 +53,7 @@ pub fn build_metastore_rolegroup_config_map(
5553
rg: &HiveRoleGroupConfig,
5654
) -> Result<ConfigMap> {
5755
// hive-site.xml
58-
let hive_site_overrides = resolved_overrides(rg.config_overrides.hive_site_xml.clone());
56+
let hive_site_overrides = rg.config_overrides.hive_site_xml.overrides.clone();
5957
let hive_site_data = hive_site::build(
6058
&cluster.cluster_config,
6159
&cluster.image.product_version,
@@ -65,7 +63,7 @@ pub fn build_metastore_rolegroup_config_map(
6563
.context(BuildHiveSiteSnafu)?;
6664

6765
// security.properties
68-
let security_overrides = resolved_overrides(rg.config_overrides.security_properties.clone());
66+
let security_overrides = rg.config_overrides.security_properties.overrides.clone();
6967
let security_data = security_properties::build(security_overrides);
7068

7169
let mut cm_builder = ConfigMapBuilder::new();

rust/operator-binary/src/controller/build/properties/mod.rs

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,24 +1,10 @@
11
//! Per-file builders for the Hive metastore config files.
22
3-
use std::collections::BTreeMap;
4-
5-
use stackable_operator::v2::config_overrides::KeyValueConfigOverrides;
6-
73
pub mod core_site;
84
pub mod hive_site;
95
pub mod logging;
106
pub mod security_properties;
117

12-
/// Resolve user-provided key/value overrides into `(key, value)` pairs, dropping
13-
/// entries whose value is unset (`None`).
14-
pub(crate) fn resolved_overrides(overrides: KeyValueConfigOverrides) -> BTreeMap<String, String> {
15-
overrides
16-
.overrides
17-
.into_iter()
18-
.filter_map(|(key, value)| value.map(|value| (key, value)))
19-
.collect()
20-
}
21-
228
/// The names of the Hive config files assembled into the rolegroup `ConfigMap`.
239
#[derive(Clone, Copy, Debug, strum::Display)]
2410
pub enum ConfigFileName {

0 commit comments

Comments
 (0)