-
-
Notifications
You must be signed in to change notification settings - Fork 8
Expand file tree
/
Copy pathjvm.rs
More file actions
207 lines (185 loc) · 6.79 KB
/
Copy pathjvm.rs
File metadata and controls
207 lines (185 loc) · 6.79 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
use snafu::{OptionExt, ResultExt, Snafu};
use stackable_operator::{
memory::{BinaryMultiple, MemoryQuantity},
role_utils::{self, GenericRoleConfig, JavaCommonConfig, JvmArgumentOverrides, Role},
};
use crate::crd::{
JVM_SECURITY_PROPERTIES_FILE, METRICS_PORT, STACKABLE_CONFIG_DIR, role::AnyConfig,
};
const JAVA_HEAP_FACTOR: f32 = 0.8;
#[derive(Snafu, Debug)]
pub enum Error {
#[snafu(display("invalid memory resource configuration - missing default or value in crd?"))]
MissingMemoryResourceConfig,
#[snafu(display("invalid memory config"))]
InvalidMemoryConfig {
source: stackable_operator::memory::Error,
},
#[snafu(display("failed to merge jvm argument overrides"))]
MergeJvmArgumentOverrides { source: role_utils::Error },
}
/// All JVM arguments.
fn construct_jvm_args<ConfigFragment>(
merged_config: &AnyConfig,
role: &Role<ConfigFragment, GenericRoleConfig, JavaCommonConfig>,
role_group: &str,
) -> Result<Vec<String>, Error> {
let heap_size = MemoryQuantity::try_from(
merged_config
.resources()
.memory
.limit
.as_ref()
.context(MissingMemoryResourceConfigSnafu)?,
)
.context(InvalidMemoryConfigSnafu)?
.scale_to(BinaryMultiple::Mebi)
* JAVA_HEAP_FACTOR;
let java_heap = heap_size
.format_for_java()
.context(InvalidMemoryConfigSnafu)?;
let jvm_args = vec![
// Heap settings
format!("-Xmx{java_heap}"),
format!("-Xms{java_heap}"),
format!("-Djava.security.properties={STACKABLE_CONFIG_DIR}/{JVM_SECURITY_PROPERTIES_FILE}"),
format!(
"-javaagent:/stackable/jmx/jmx_prometheus_javaagent.jar={METRICS_PORT}:/stackable/jmx/broker.yaml"
),
];
let operator_generated = JvmArgumentOverrides::new_with_only_additions(jvm_args);
let merged = role
.get_merged_jvm_argument_overrides(role_group, &operator_generated)
.context(MergeJvmArgumentOverridesSnafu)?;
Ok(merged
.effective_jvm_config_after_merging()
// Sorry for the clone, that's how operator-rs is currently modelled :P
.clone())
}
/// Arguments that go into `EXTRA_ARGS`, so *not* the heap settings (which you can get using
/// [`construct_heap_jvm_args`]).
pub fn construct_non_heap_jvm_args<ConfigFragment>(
merged_config: &AnyConfig,
role: &Role<ConfigFragment, GenericRoleConfig, JavaCommonConfig>,
role_group: &str,
) -> Result<String, Error> {
let mut jvm_args = construct_jvm_args(merged_config, role, role_group)?;
jvm_args.retain(|arg| !is_heap_jvm_argument(arg));
Ok(jvm_args.join(" "))
}
/// Arguments that go into `KAFKA_HEAP_OPTS`.
/// You can get the normal JVM arguments using [`construct_non_heap_jvm_args`].
pub fn construct_heap_jvm_args<ConfigFragment>(
merged_config: &AnyConfig,
role: &Role<ConfigFragment, GenericRoleConfig, JavaCommonConfig>,
role_group: &str,
) -> Result<String, Error> {
let mut jvm_args = construct_jvm_args(merged_config, role, role_group)?;
jvm_args.retain(|arg| is_heap_jvm_argument(arg));
Ok(jvm_args.join(" "))
}
fn is_heap_jvm_argument(jvm_argument: &str) -> bool {
let lowercase = jvm_argument.to_lowercase();
lowercase.starts_with("-xms") || lowercase.starts_with("-xmx")
}
#[cfg(test)]
mod tests {
use super::*;
use crate::crd::{
role::{KafkaRole, broker::BrokerConfigFragment},
v1alpha1,
};
#[test]
fn test_construct_jvm_arguments_defaults() {
let input = r#"
apiVersion: kafka.stackable.tech/v1alpha1
kind: KafkaCluster
metadata:
name: simple-kafka
spec:
image:
productVersion: 3.9.1
clusterConfig:
zookeeperConfigMapName: xyz
brokers:
roleGroups:
default:
replicas: 1
"#;
let (kafka_role, role, merged_config) = construct_boilerplate(input);
let non_heap_jvm_args =
construct_non_heap_jvm_args(&kafka_role, &role, &merged_config).unwrap();
let heap_jvm_args = construct_heap_jvm_args(&kafka_role, &role, &merged_config).unwrap();
assert_eq!(
non_heap_jvm_args,
"-Djava.security.properties=/stackable/config/security.properties \
-javaagent:/stackable/jmx/jmx_prometheus_javaagent.jar=9606:/stackable/jmx/broker.yaml"
);
assert_eq!(heap_jvm_args, "-Xmx1638m -Xms1638m");
}
#[test]
fn test_construct_jvm_argument_overrides() {
let input = r#"
apiVersion: kafka.stackable.tech/v1alpha1
kind: KafkaCluster
metadata:
name: simple-kafka
spec:
image:
productVersion: 3.9.1
clusterConfig:
zookeeperConfigMapName: xyz
brokers:
config:
resources:
memory:
limit: 42Gi
jvmArgumentOverrides:
add:
- -Dhttps.proxyHost=proxy.my.corp
- -Dhttps.proxyPort=8080
- -Djava.net.preferIPv4Stack=true
roleGroups:
default:
replicas: 1
jvmArgumentOverrides:
# We need more memory!
removeRegex:
- -Xmx.*
- -Dhttps.proxyPort=.*
add:
- -Xmx40000m
- -Dhttps.proxyPort=1234
"#;
let (merged_config, role, role_group) = construct_boilerplate(input);
let non_heap_jvm_args =
construct_non_heap_jvm_args(&merged_config, &role, &role_group).unwrap();
let heap_jvm_args = construct_heap_jvm_args(&merged_config, &role, &role_group).unwrap();
assert_eq!(
non_heap_jvm_args,
"-Djava.security.properties=/stackable/config/security.properties \
-javaagent:/stackable/jmx/jmx_prometheus_javaagent.jar=9606:/stackable/jmx/broker.yaml \
-Dhttps.proxyHost=proxy.my.corp \
-Djava.net.preferIPv4Stack=true \
-Dhttps.proxyPort=1234"
);
assert_eq!(heap_jvm_args, "-Xms34406m -Xmx40000m");
}
fn construct_boilerplate(
kafka_cluster: &str,
) -> (
AnyConfig,
Role<BrokerConfigFragment, GenericRoleConfig, JavaCommonConfig>,
String,
) {
let kafka: v1alpha1::KafkaCluster =
serde_yaml::from_str(kafka_cluster).expect("illegal test input");
let kafka_role = KafkaRole::Broker;
let rolegroup_ref = kafka.rolegroup_ref(&kafka_role, "default");
let merged_config = kafka_role
.merged_config(&kafka, &rolegroup_ref.role_group)
.unwrap();
let role = kafka.spec.brokers.unwrap();
(merged_config, role, "default".to_owned())
}
}