Skip to content

Commit 18df143

Browse files
adwk67maltesander
andauthored
Apply suggestions from code review
Co-authored-by: maltesander <contact@maltesander.com>
1 parent f580049 commit 18df143

4 files changed

Lines changed: 0 additions & 4 deletions

File tree

rust/operator-binary/src/controller/build/discovery.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ pub fn build_discovery_configmap(
6565
.metadata(
6666
ObjectMetaBuilder::new()
6767
.name_and_namespace(validated_cluster)
68-
.name(validated_cluster.name.to_string())
6968
.ownerreference_from_resource(validated_cluster, None, Some(true))
7069
.with_context(|_| ObjectMissingMetadataForOwnerRefSnafu {
7170
kafka: cluster_object_ref(validated_cluster),

rust/operator-binary/src/crd/config_file.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
//! A single source of truth for the on-disk file names, used by the config-map
44
//! builder, the per-file property builders, the JVM/command builders and
55
//! [`AnyConfig::config_file_name`](crate::crd::role::AnyConfig::config_file_name).
6-
//! Mirrors the hive-operator's `ConfigFileName`.
76
87
/// The names of the Kafka config files assembled into the rolegroup `ConfigMap`.
98
#[derive(Clone, Copy, Debug, PartialEq, Eq, strum::Display)]

rust/operator-binary/src/crd/role/broker.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,4 +93,3 @@ impl BrokerConfig {
9393
}
9494
}
9595

96-
// KAFKA_CLUSTER_ID injection moved to controller/validate.rs::collect_broker_role_group_overrides.

rust/operator-binary/src/crd/role/controller.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,4 +84,3 @@ impl ControllerConfig {
8484
}
8585
}
8686

87-
// KAFKA_CLUSTER_ID injection moved to controller/validate.rs::collect_controller_role_group_overrides.

0 commit comments

Comments
 (0)