Skip to content

Commit bb27d44

Browse files
maltesanderrazvan
andauthored
Apply suggestions from code review
Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
1 parent 4819744 commit bb27d44

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

docs/modules/kafka/pages/usage-guide/kraft-controller.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ KRaft mode requires major configuration changes compared to ZooKeeper:
8383
* `cluster-id`: This is set to the `metadata.name` of the KafkaCluster resource during initial formatting
8484
* `node.id`: This is a calculated integer, hashed from the `role` and `rolegroup` and added `replica` id.
8585
* `process.roles`: Will always only be `broker` or `controller`. Mixed `broker,controller` servers are not supported.
86-
86+
* The operator configures a static voter list containing the controller pods. Controllers are not dynamicaly managed.
8787
== Troubleshooting
8888

8989
=== Cluster does not start

rust/operator-binary/src/crd/role/mod.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ pub const KAFKA_NODE_ID: &str = "node.id";
4141
/// The roles that this process plays: 'broker', 'controller', or 'broker,controller' if it is both.
4242
pub const KAFKA_PROCESS_ROLES: &str = "process.roles";
4343

44-
/// A comma-separated list of the directories where the log data is stored. If not set, the value in log.dir is used.
44+
/// A comma-separated list of the directories where the topic data is stored.
4545
pub const KAFKA_LOG_DIRS: &str = "log.dirs";
4646

4747
/// Listener List - Comma-separated list of URIs we will listen on and the listener names.
@@ -132,7 +132,6 @@ impl KafkaRole {
132132
}
133133

134134
/// A Kerberos principal has three parts, with the form username/fully.qualified.domain.name@YOUR-REALM.COM.
135-
/// We only have one role and will use "kafka" everywhere (which e.g. differs from the current hdfs implementation,
136135
/// but is similar to HBase).
137136
// TODO: split into broker / controller?
138137
pub fn kerberos_service_name(&self) -> &'static str {

0 commit comments

Comments
 (0)