Skip to content

Commit d0956aa

Browse files
authored
Apply suggestions from code review
Co-authored-by: maltesander <malte.sander.it@gmail.com>
1 parent 9d4cf1f commit d0956aa

1 file changed

Lines changed: 0 additions & 8 deletions

File tree

  • rust/operator-binary/src/controller/build/properties/product_logging

rust/operator-binary/src/controller/build/properties/product_logging/mod.rs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,6 @@ const KAFKA_LOG4J_FILE: &str = "kafka.log4j.xml";
2525
const KAFKA_LOG4J2_FILE: &str = "kafka.log4j2.xml";
2626

2727
/// The static, env-driven Vector agent configuration (`vector.yaml`).
28-
///
29-
/// The [`vector_container`](stackable_operator::v2::product_logging::framework::vector_container)
30-
/// mounts this file and supplies its `${...}` values (`LOG_DIR`, `DATA_DIR`, `NAMESPACE`,
31-
/// `CLUSTER_NAME`, `ROLE_NAME`, `ROLE_GROUP_NAME`, `VECTOR_AGGREGATOR_ADDRESS`) as env vars.
3228
const VECTOR_CONFIG: &str = include_str!("vector.yaml");
3329

3430
/// Returns the Vector agent config (`vector.yaml`) content.
@@ -144,9 +140,5 @@ mod tests {
144140
// The two Kafka log formats must be handled ...
145141
assert!(content.contains("files_log4j"));
146142
assert!(content.contains("files_log4j2"));
147-
// ... while the non-Kafka sources were removed.
148-
assert!(!content.contains("files_stdout"));
149-
assert!(!content.contains("files_tracing_rs"));
150-
assert!(!content.contains("files_opa_json"));
151143
}
152144
}

0 commit comments

Comments
 (0)