Skip to content

Commit e5f366b

Browse files
committed
fix docs
1 parent ce171c0 commit e5f366b

4 files changed

Lines changed: 8 additions & 7 deletions

File tree

rust/operator-binary/src/crd/mod.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -341,7 +341,7 @@ pub struct KafkaPodDescriptor {
341341

342342
impl KafkaPodDescriptor {
343343
/// Return the fully qualified domain name
344-
/// Format: <pod-name>.<service>.<namespace>.svc.<cluster-domain>
344+
/// Format: `<pod-name>.<service>.<namespace>.svc.<cluster-domain>`
345345
pub fn fqdn(&self) -> String {
346346
format!(
347347
"{pod_name}.{service_name}.{namespace}.svc.{cluster_domain}",
@@ -357,11 +357,11 @@ impl KafkaPodDescriptor {
357357
}
358358

359359
/// Build the Kraft voter String
360-
/// See: https://kafka.apache.org/documentation/#kraft_storage_voters
360+
/// See: <https://kafka.apache.org/documentation/#kraft_storage_voters>
361361
/// Example: 0@controller-0:1234:0000000000-00000000000
362362
/// * 0 is the replica id
363363
/// * 0000000000-00000000000 is the replica directory id (even though the used Uuid states to be type 4 it does not work)
364-
/// See: https://github.com/apache/kafka/blob/c5169ca805bd03d870a5bcd49744dcc34891cf15/clients/src/main/java/org/apache/kafka/common/Uuid.java#L29
364+
/// See: <https://github.com/apache/kafka/blob/c5169ca805bd03d870a5bcd49744dcc34891cf15/clients/src/main/java/org/apache/kafka/common/Uuid.java#L29>
365365
/// * controller-0 is the replica's host,
366366
/// * 1234 is the replica's port.
367367
// TODO(@maltesander): Even though the used Uuid states to be type 4 it does not work... 0000000000-00000000000 works...

rust/operator-binary/src/kafka_controller.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ use crate::{
4949
resource::{
5050
configmap::build_rolegroup_config_map,
5151
listener::build_broker_rolegroup_bootstrap_listener,
52-
service::build_broker_rolegroup_service,
52+
service::build_rolegroup_service,
5353
statefulset::{build_broker_rolegroup_statefulset, build_controller_rolegroup_statefulset},
5454
},
5555
};
@@ -348,7 +348,7 @@ pub async fn reconcile_kafka(
348348
.context(FailedToResolveConfigSnafu)?;
349349

350350
let rg_service =
351-
build_broker_rolegroup_service(kafka, &resolved_product_image, &rolegroup_ref)
351+
build_rolegroup_service(kafka, &resolved_product_image, &rolegroup_ref)
352352
.context(BuildServiceSnafu)?;
353353

354354
let rg_configmap = build_rolegroup_config_map(

rust/operator-binary/src/resource/service.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ pub enum Error {
3434
/// The rolegroup [`Service`] is a headless service that allows direct access to the instances of a certain rolegroup
3535
///
3636
/// This is mostly useful for internal communication between peers, or for clients that perform client-side load balancing.
37-
pub fn build_broker_rolegroup_service(
37+
pub fn build_rolegroup_service(
3838
kafka: &v1alpha1::KafkaCluster,
3939
resolved_product_image: &ResolvedProductImage,
4040
rolegroup: &RoleGroupRef<v1alpha1::KafkaCluster>,

rust/operator-binary/src/resource/statefulset.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,8 @@ pub enum Error {
155155

156156
/// The broker rolegroup [`StatefulSet`] runs the rolegroup, as configured by the administrator.
157157
///
158-
/// The [`Pod`](`stackable_operator::k8s_openapi::api::core::v1::Pod`)s are accessible through the corresponding [`Service`] (from [`build_broker_rolegroup_service`]).
158+
/// The [`Pod`](`stackable_operator::k8s_openapi::api::core::v1::Pod`)s are accessible through the corresponding
159+
/// [`Service`](`stackable_operator::k8s_openapi::api::core::v1::Service`) from [`build_rolegroup_service`](`crate::resource::service::build_rolegroup_service`).
159160
#[allow(clippy::too_many_arguments)]
160161
pub fn build_broker_rolegroup_statefulset(
161162
kafka: &v1alpha1::KafkaCluster,

0 commit comments

Comments
 (0)