fix: remove error & comment cleanup

Author: maltesander

rust/operator-binary/src/config/jvm.rs

@@ -30,7 +30,7 @@ pub enum Error {
     MergeJvmArgumentOverrides { source: role_utils::Error },
 }
 
-/// Create the NiFi bootstrap.conf
+/// Build the merged JVM argument overrides used in the NiFi bootstrap.conf
 pub fn build_merged_jvm_config(
     merged_config: &NifiConfig,
     role: &NifiRoleType,

rust/operator-binary/src/controller.rs

@@ -217,11 +217,6 @@ pub enum Error {
         source: stackable_operator::commons::rbac::Error,
     },
 
-    #[snafu(display("Invalid NiFi Authorization Configuration"))]
-    InvalidNifiAuthorizationConfig {
-        source: crate::security::authorization::Error,
-    },
-
     #[snafu(display("failed to create PodDisruptionBudget"))]
     FailedToCreatePdb {
         source: crate::operations::pdb::Error,

rust/operator-binary/src/crd/mod.rs

@@ -211,7 +211,7 @@ impl HasStatusCondition for v1alpha1::NifiCluster {
 }
 
 impl v1alpha1::NifiCluster {
-    /// Metadata about a metastore rolegroup
+    /// Metadata about a Node rolegroup
     pub fn node_rolegroup_ref(&self, group_name: impl Into<String>) -> RoleGroupRef<Self> {
         RoleGroupRef {
             cluster: ObjectRef::from_obj(self),

rust/operator-binary/src/reporting_task/mod.rs

@@ -149,7 +149,7 @@ pub fn build_maybe_reporting_task(
     }
 }
 
-/// Return the name of the reporting task.
+/// Return the name of the reporting task Service.
 pub fn build_reporting_task_service_name(nifi_cluster_name: &str) -> String {
     format!("{nifi_cluster_name}-{REPORTING_TASK_CONTAINER_NAME}")
 }

rust/operator-binary/src/security/authentication.rs

@@ -206,8 +206,8 @@ impl NifiAuthenticationConfig {
         commands
     }
 
-    /// Returns
-    /// - A list of extra commands for the init container
+    /// Adds the volumes and volume mounts required by the configured authentication
+    /// method to the pod and the given container builders.
     pub fn add_volumes_and_mounts(
         &self,
         pod_builder: &mut PodBuilder,