fix: rename build sts replicas to effective_replicas (due to upgrade logic) to clarify usage

Author: maltesander

rust/operator-binary/src/controller/build/resource/statefulset.rs

@@ -175,7 +175,7 @@ pub(crate) async fn build_node_rolegroup_statefulset(
     role_group_name: &RoleGroupName,
     rg: &NifiRoleGroupConfig,
     rolling_update_supported: bool,
-    replicas: Option<i32>,
+    effective_replicas: Option<i32>,
     service_account_name: &str,
 ) -> Result<StatefulSet> {
     tracing::debug!("Building statefulset");
@@ -675,7 +675,7 @@ pub(crate) async fn build_node_rolegroup_statefulset(
             .build(),
         spec: Some(StatefulSetSpec {
             pod_management_policy: Some("Parallel".to_string()),
-            replicas,
+            replicas: effective_replicas,
             selector: LabelSelector {
                 match_labels: Some(cluster.role_group_selector(role_group_name).into()),
                 ..LabelSelector::default()

rust/operator-binary/src/nifi_controller.rs

@@ -301,12 +301,10 @@ pub async fn reconcile_nifi(
                 rolegroup: role_group_name.clone(),
             })?;
 
-            let replicas =
+            let effective_replicas =
                 if cluster_version_update_state == ClusterVersionUpdateState::UpdateRequested {
                     Some(0)
                 } else {
-                    // `None` (HPA-managed role group) is passed straight through to the StatefulSet
-                    // so the Horizontal Pod Autoscaler owns the replica count.
                     rg.replicas.map(i32::from)
                 };
 
@@ -316,7 +314,7 @@ pub async fn reconcile_nifi(
                 role_group_name,
                 rg,
                 rolling_upgrade_supported,
-                replicas,
+                effective_replicas,
                 &rbac_sa.name_any(),
             )
             .await