fix: addressed review feedback

Author: dervoeti

rust/operator-binary/src/crd/mod.rs

@@ -196,13 +196,13 @@ pub mod versioned {
     #[derive(Clone, Debug, Default, Deserialize, JsonSchema, PartialEq, Serialize)]
     #[serde(rename_all = "camelCase")]
     pub struct NifiConfigOverrides {
-        #[serde(rename = "bootstrap.conf")]
+        #[serde(rename = "bootstrap.conf", skip_serializing_if = "Option::is_none")]
         pub bootstrap_conf: Option<KeyValueConfigOverrides>,
 
-        #[serde(rename = "nifi.properties")]
+        #[serde(rename = "nifi.properties", skip_serializing_if = "Option::is_none")]
         pub nifi_properties: Option<KeyValueConfigOverrides>,
 
-        #[serde(rename = "security.properties")]
+        #[serde(rename = "security.properties", skip_serializing_if = "Option::is_none")]
         pub security_properties: Option<KeyValueConfigOverrides>,
     }
 }

rust/operator-binary/src/security/authorization.rs

@@ -237,12 +237,12 @@ impl ResolvedNifiAuthorizationConfig {
             ..
         } = self
         {
-            // NiFi needs the public CA certificate to verify the OPA server's cert.
             volumes.push(
                 VolumeBuilder::new(OPA_TLS_VOLUME_NAME)
                     .ephemeral(
                         SecretOperatorVolumeSourceBuilder::new(
                             secret_class,
+                            // NiFi needs the public CA certificate to verify the OPA server's cert.
                             SecretClassVolumeProvisionParts::Public,
                         )
                         .build()

rust/operator-binary/src/security/tls.rs

@@ -30,10 +30,10 @@ pub(crate) fn build_tls_volume(
     requested_secret_lifetime: &Duration,
     listener_scope: Option<&str>,
 ) -> Result<Volume> {
-    // NiFi serves its own TLS endpoints, so the Pod needs both the public
-    // certificate and the private key.
     let mut secret_volume_source_builder = SecretOperatorVolumeSourceBuilder::new(
         nifi.server_tls_secret_class(),
+        // NiFi serves its own TLS endpoints, so the Pod needs both the public
+        // certificate and the private key.
         SecretClassVolumeProvisionParts::PublicPrivate,
     );