chore: bump Rust edition to 2024 and apply cargo fix + clippy updates (#943)

* chore: bump Rust edition to 2024 and apply cargo fix + clippy updates

Run `cargo fix --edition` and resolve resulting warnings:

- Add `use<>` syntax to `impl Trait` return types (auto-fixed)
- Fix Rust 2024 temporary drop order change by simplifying `_initial_reconcile_rx` handling
- Apply rustFMT suggestions

* Fix: Update built to address RustSec advisories

* Fix: update dependencies for RustSec advisories

* Update generated Cargo.nix

* Update Cargo.toml

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.tech>

---------

Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.tech>

Author: Saul-STFC

Cargo.nix

@@ -6,7 +6,7 @@ resolver = "2"
 version = "0.0.0-dev"
 authors = ["Stackable GmbH <info@stackable.tech>"]
 license = "OSL-3.0"
-edition = "2021"
+edition = "2024"
 repository = "https://github.com/stackabletech/nifi-operator"
 
 [workspace.dependencies]

Cargo.toml

@@ -97,16 +97,16 @@ pub fn build_merged_jvm_config(
     // respects these JVM-wide SSL system properties. So there is no plugin-level configuration
     // available for truststore settings. This was last checked for version 1.7.0 of the Styra
     // OPA Java SDK.
-    if let Some(authz_config) = authorization_config {
-        if authz_config.has_opa_tls() {
-            operator_generated.push(format!(
-                "-Djavax.net.ssl.trustStore={STACKABLE_SERVER_TLS_DIR}/truststore.p12"
-            ));
-            operator_generated.push(format!(
-                "-Djavax.net.ssl.trustStorePassword={STACKABLE_TLS_STORE_PASSWORD}"
-            ));
-            operator_generated.push("-Djavax.net.ssl.trustStoreType=pkcs12".to_owned());
-        }
+    if let Some(authz_config) = authorization_config
+        && authz_config.has_opa_tls()
+    {
+        operator_generated.push(format!(
+            "-Djavax.net.ssl.trustStore={STACKABLE_SERVER_TLS_DIR}/truststore.p12"
+        ));
+        operator_generated.push(format!(
+            "-Djavax.net.ssl.trustStorePassword={STACKABLE_TLS_STORE_PASSWORD}"
+        ));
+        operator_generated.push("-Djavax.net.ssl.trustStoreType=pkcs12".to_owned());
     }
 
     Ok(merged_jvm_argument_overrides.apply_to(operator_generated))

rust/operator-binary/src/controller/build/jvm.rs

@@ -40,7 +40,7 @@ pub async fn create_webhook_server(
         field_manager: FIELD_MANAGER.to_owned(),
     };
 
-    let (conversion_webhook, _initial_reconcile_rx) =
+    let (conversion_webhook, _) =
         ConversionWebhook::new(crds_and_handlers, client, conversion_webhook_options);
 
     let webhook_server_options = WebhookServerOptions {