Skip to content

Commit f28fdb7

Browse files
committed
feat: Lookup Superset things (by id)
1 parent d56a198 commit f28fdb7

2 files changed

Lines changed: 12 additions & 5 deletions

File tree

rust/resource-info-fetcher/src/api.rs

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,12 @@ pub enum ResourceInfoRequestResource {
4242
catalog: String,
4343
},
4444

45-
SupersetChart(String),
46-
SupersetDashboard(String),
47-
45+
SupersetChart {
46+
id: u64,
47+
},
48+
SupersetDashboard {
49+
id: u64,
50+
},
4851
RawDataHubUrn(String),
4952
}
5053

rust/resource-info-fetcher/src/backend/data_hub/resource_to_urn_mapping.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,12 @@ pub fn urn_for_request(request: &ResourceInfoRequest, env: &str) -> Urn {
3333
("schema", schema.as_str()),
3434
]))
3535
}
36-
ResourceInfoRequestResource::SupersetChart(_) => todo!(),
37-
ResourceInfoRequestResource::SupersetDashboard(_) => todo!(),
36+
ResourceInfoRequestResource::SupersetChart { id } => {
37+
format!("urn:li:chart:({stacklet},{id})")
38+
}
39+
ResourceInfoRequestResource::SupersetDashboard { id } => {
40+
format!("urn:li:dashboard:({stacklet},{id})")
41+
}
3842
ResourceInfoRequestResource::RawDataHubUrn(urn) => urn.to_owned(),
3943
};
4044

0 commit comments

Comments
 (0)