chore: Split the roles.yaml into separate files for clusterrole-operator.yaml and clusterrole-product.yaml

Author: NickLarsenNZ

…opensearch-operator/templates/roles.yaml …ator/templates/clusterrole-operator.yamldeploy/helm/opensearch-operator/templates/roles.yaml renamed to deploy/helm/opensearch-operator/templates/clusterrole-operator.yaml deploy/helm/opensearch-operator/templates/roles.yaml renamed to deploy/helm/opensearch-operator/templates/clusterrole-operator.yaml

@@ -1,3 +1,4 @@
+---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:
@@ -128,22 +129,3 @@ rules:
       - {{ include "operator.name" . }}clusters/status
     verbs:
       - patch
----
-apiVersion: rbac.authorization.k8s.io/v1
-kind: ClusterRole
-metadata:
-  name: {{ include "operator.name" . }}-clusterrole
-  labels:
-  {{- include "operator.labels" . | nindent 4 }}
-rules:
-{{ if .Capabilities.APIVersions.Has "security.openshift.io/v1" }}
-  # Required on OpenShift to allow the OpenSearch pods to run as a non-root user.
-  - apiGroups:
-      - security.openshift.io
-    resources:
-      - securitycontextconstraints
-    resourceNames:
-      - nonroot-v2
-    verbs:
-      - use
-{{ end }}

deploy/helm/opensearch-operator/templates/clusterrole-product.yaml

@@ -0,0 +1,21 @@
+---
+# Product ClusterRole: bound (via per OpenSearchCluster RoleBinding) to the ServiceAccount that
+# OpenSearch workload pods run as.
+apiVersion: rbac.authorization.k8s.io/v1
+kind: ClusterRole
+metadata:
+  name: {{ include "operator.name" . }}-clusterrole
+  labels:
+  {{- include "operator.labels" . | nindent 4 }}
+rules:
+{{ if .Capabilities.APIVersions.Has "security.openshift.io/v1" }}
+  # Required on OpenShift to allow the OpenSearch pods to run as a non-root user.
+  - apiGroups:
+      - security.openshift.io
+    resources:
+      - securitycontextconstraints
+    resourceNames:
+      - nonroot-v2
+    verbs:
+      - use
+{{ end }}