test(metrics): Fix the test on OpenShift

Author: siegfriedweber

tests/templates/kuttl/metrics/01-rbac.yaml

@@ -1,37 +1,7 @@
 ---
-apiVersion: v1
-kind: ServiceAccount
-metadata:
-  name: test-service-account
----
-kind: Role
-apiVersion: rbac.authorization.k8s.io/v1
-metadata:
-  name: test-role
-rules:
-  - apiGroups:
-      - security.openshift.io
-    resources:
-      - securitycontextconstraints
-    resourceNames:
-      - privileged
-    verbs:
-      - use
----
-kind: RoleBinding
-apiVersion: rbac.authorization.k8s.io/v1
-metadata:
-  name: test-role-binding
-subjects:
-  - kind: ServiceAccount
-    name: test-service-account
-  - kind: ServiceAccount
-    name: prometheus-stack-kube-prom-admission
-  - kind: ServiceAccount
-    name: prometheus-stack-kube-prom-operator
-  - kind: ServiceAccount
-    name: prometheus-stack-kube-prom-prometheus
-roleRef:
-  apiGroup: rbac.authorization.k8s.io
-  kind: Role
-  name: test-role
+apiVersion: kuttl.dev/v1beta1
+kind: TestStep
+commands:
+  - script: >
+      envsubst '$NAMESPACE' < 01_rbac.yaml |
+      kubectl apply -n $NAMESPACE -f -

tests/templates/kuttl/metrics/01_rbac.yaml

@@ -0,0 +1,39 @@
+---
+apiVersion: v1
+kind: ServiceAccount
+metadata:
+  name: test-service-account
+---
+kind: Role
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: test-role
+rules:
+  - apiGroups:
+      - security.openshift.io
+    resources:
+      - securitycontextconstraints
+    resourceNames:
+      - privileged
+    verbs:
+      - use
+---
+# `fullnameOverride` in the Prometheus Helm values must be set to `prometheus-$NAMESPACE`, so that
+# the ServiceAccounts are created with the names listed in this RoleBinding.
+kind: RoleBinding
+apiVersion: rbac.authorization.k8s.io/v1
+metadata:
+  name: test-role-binding
+subjects:
+  - kind: ServiceAccount
+    name: test-service-account
+  - kind: ServiceAccount
+    name: prometheus-$NAMESPACE-admission
+  - kind: ServiceAccount
+    name: prometheus-$NAMESPACE-operator
+  - kind: ServiceAccount
+    name: prometheus-$NAMESPACE-prometheus
+roleRef:
+  apiGroup: rbac.authorization.k8s.io
+  kind: Role
+  name: test-role

tests/templates/kuttl/metrics/10-install-prometheus.yaml

@@ -2,13 +2,15 @@
 apiVersion: kuttl.dev/v1beta1
 kind: TestStep
 commands:
-  # Append the namespace to the Helm release name so that cluster-wide
-  # resources get unique names.
+  # Append the namespace to the Helm release name so that cluster-wide resources get unique names.
+  # `fullnameOverride` is set to `prometheus-$NAMESPACE`, so that the ServiceAccounts are created
+  # with the names that are defined in `test-role-binding`.
   - script: >
       helm install prometheus-$NAMESPACE
       --namespace $NAMESPACE
       --version 80.14.2
       --values 10_kube-prometheus-stack-values.yaml
+      --set fullnameOverride=prometheus-$NAMESPACE
       --wait
       oci://ghcr.io/prometheus-community/charts/kube-prometheus-stack
     timeout: 600