Fix shellcheck warnings

Author: siegfriedweber

rust/operator-binary/src/controller/build/role_group_builder.rs

@@ -666,13 +666,10 @@ cp --archive config/opensearch.keystore {OPENSEARCH_INITIALIZED_KEYSTORE_DIRECTO
                 .expect("should be a valid container name"),
         )
         .image_from_product_image(&self.cluster.image)
-        .command(vec![
-            "/bin/bash".to_string(),
-            "-euo".to_string(),
-            "pipefail".to_string(),
-            "-c".to_string(),
+        .command(vec!["/bin/bash".to_string(), "-c".to_string()])
+        .args(vec![
+            include_str!("scripts/create-admin-certificate.sh").to_owned(),
         ])
-        .args(vec![include_str!("create-admin-certificate.sh").to_owned()])
         .add_env_vars(env_vars.into())
         .add_volume_mounts(volume_mounts)
         .expect("The mount paths are statically defined and there should be no duplicates.")
@@ -754,13 +751,10 @@ cp --archive config/opensearch.keystore {OPENSEARCH_INITIALIZED_KEYSTORE_DIRECTO
 
         new_container_builder(&v1alpha1::Container::UpdateSecurityConfig.to_container_name())
             .image_from_product_image(&self.cluster.image)
-            .command(vec![
-                "/bin/bash".to_string(),
-                "-uo".to_string(),
-                "pipefail".to_string(),
-                "-c".to_string(),
+            .command(vec!["/bin/bash".to_string(), "-c".to_string()])
+            .args(vec![
+                include_str!("scripts/update-security-config.sh").to_owned(),
             ])
-            .args(vec![include_str!("update-security-config.sh").to_owned()])
             .add_env_vars(env_vars.into())
             .add_volume_mounts(volume_mounts)
             .expect("The mount paths are statically defined and there should be no duplicates.")

…roller/build/create-admin-certificate.sh …uild/scripts/create-admin-certificate.shrust/operator-binary/src/controller/build/create-admin-certificate.sh renamed to rust/operator-binary/src/controller/build/scripts/create-admin-certificate.sh rust/operator-binary/src/controller/build/create-admin-certificate.sh renamed to rust/operator-binary/src/controller/build/scripts/create-admin-certificate.sh

@@ -1,3 +1,7 @@
+#!/usr/bin/env bash
+
+set -e -u -o pipefail
+
 function log () {
     level="$1"
     message="$2"
@@ -7,7 +11,7 @@ function log () {
 }
 
 function info () {
-    message="$@"
+    message="$*"
 
     log INFO "$message"
 }
@@ -39,7 +43,7 @@ function create_admin_certificate () {
     openssl req \
         -x509 \
         -nodes \
-        -subj=/$ADMIN_DN \
+        -subj=/"$ADMIN_DN" \
         -out=/stackable/tls-admin-cert/tls.crt \
         -keyout=/stackable/tls-admin-cert/tls.key
 }

…ntroller/build/update-security-config.sh …/build/scripts/update-security-config.shrust/operator-binary/src/controller/build/update-security-config.sh renamed to rust/operator-binary/src/controller/build/scripts/update-security-config.sh rust/operator-binary/src/controller/build/update-security-config.sh renamed to rust/operator-binary/src/controller/build/scripts/update-security-config.sh

@@ -1,3 +1,7 @@
+#!/usr/bin/env bash
+
+set -u -o pipefail
+
 function log () {
     level="$1"
     message="$2"
@@ -7,7 +11,7 @@ function log () {
 }
 
 function info () {
-    message="$@"
+    message="$*"
 
     log INFO "$message"
 }
@@ -33,7 +37,7 @@ function wait_seconds () {
         mkdir --parents /stackable/log/_vector
         inotifywait \
             --quiet --quiet \
-            --timeout $seconds \
+            --timeout "$seconds" \
             --event create \
             /stackable/log/_vector
     fi