test: Add unit tests for Port

Author: siegfriedweber

rust/operator-binary/src/controller/validate.rs

@@ -993,7 +993,6 @@ mod tests {
                 spec: listener::v1alpha1::ListenerSpec::default(),
                 status: Some(listener::v1alpha1::ListenerStatus {
                     ingress_addresses: Some(vec![listener::v1alpha1::ListenerIngress {
-                        // TODO Check if it is the FQDN
                         address: "my-opensearch.default.svc.cluster.local".to_owned(),
                         address_type: listener::v1alpha1::AddressType::Hostname,
                         ports: [("http".to_owned(), 9200)].into(),

rust/operator-binary/src/framework/controller_utils.rs

@@ -87,19 +87,19 @@ mod tests {
         type DynamicType = ();
 
         fn kind(_dyntype: &Self::DynamicType) -> std::borrow::Cow<'_, str> {
-            "".into()
+            "TestResource".into()
         }
 
         fn group(_dyntype: &Self::DynamicType) -> std::borrow::Cow<'_, str> {
-            todo!()
+            "stackable.tech".into()
         }
 
         fn version(_dyntype: &Self::DynamicType) -> std::borrow::Cow<'_, str> {
-            todo!()
+            "v1".into()
         }
 
         fn plural(_dyntype: &Self::DynamicType) -> std::borrow::Cow<'_, str> {
-            todo!()
+            "testresources".into()
         }
 
         fn name(&self) -> Option<std::borrow::Cow<'_, str>> {
@@ -111,7 +111,7 @@ mod tests {
         }
 
         fn resource_version(&self) -> Option<std::borrow::Cow<'_, str>> {
-            todo!()
+            Some("1".into())
         }
 
         fn uid(&self) -> Option<std::borrow::Cow<'_, str>> {

rust/operator-binary/src/framework/types/common.rs

@@ -1,3 +1,4 @@
+//! Common types that do not belong (yet) to a more specific module
 use snafu::{ResultExt, Snafu};
 use strum::{EnumDiscriminants, IntoStaticStr};
 
@@ -8,6 +9,7 @@ pub enum Error {
     ConvertToPortNumber { source: std::num::TryFromIntError },
 }
 
+/// A port number
 #[derive(Clone, Debug, Eq, PartialEq)]
 pub struct Port(pub u16);
 
@@ -32,3 +34,29 @@ impl From<Port> for i32 {
         value.0 as i32
     }
 }
+
+#[cfg(test)]
+mod tests {
+
+    use super::{ErrorDiscriminants, Port};
+
+    #[test]
+    fn test_port_fmt() {
+        assert_eq!("0".to_owned(), Port(0).to_string());
+        assert_eq!("65535".to_owned(), Port(65535).to_string());
+    }
+
+    #[test]
+    fn test_port_try_from_i32() {
+        assert_eq!(Some(Port(0)), Port::try_from(0).ok());
+        assert_eq!(Some(Port(65535)), Port::try_from(65535).ok());
+        assert_eq!(
+            Err(ErrorDiscriminants::ConvertToPortNumber),
+            Port::try_from(-1).map_err(ErrorDiscriminants::from)
+        );
+        assert_eq!(
+            Err(ErrorDiscriminants::ConvertToPortNumber),
+            Port::try_from(65536).map_err(ErrorDiscriminants::from)
+        );
+    }
+}