test: Add unit test for RoleGroupBuilder::build_node_role_label

Author: siegfriedweber

rust/operator-binary/src/controller/build/role_group_builder.rs

@@ -233,7 +233,8 @@ impl<'a> RoleGroupBuilder<'a> {
     }
 
     fn build_node_role_label(node_role: &v1alpha1::NodeRole) -> Label {
-        // TODO Check the maximum length at compile-time
+        // It is not possible to check the infallibility of the following statement at
+        // compile-time. Instead, it is tested in `tests::test_build_node_role_label`.
         Label::try_from((
             format!("stackable.tech/opensearch-role.{node_role}"),
             "true".to_string(),
@@ -444,3 +445,17 @@ impl<'a> RoleGroupBuilder<'a> {
         )
     }
 }
+
+#[cfg(test)]
+mod tests {
+    use strum::IntoEnumIterator;
+
+    use crate::{controller::build::role_group_builder::RoleGroupBuilder, crd::v1alpha1};
+
+    #[test]
+    fn test_build_node_role_label() {
+        for node_role in v1alpha1::NodeRole::iter() {
+            RoleGroupBuilder::build_node_role_label(&node_role);
+        }
+    }
+}

rust/operator-binary/src/crd/mod.rs

@@ -23,7 +23,7 @@ use stackable_operator::{
     time::Duration,
     versioned::versioned,
 };
-use strum::Display;
+use strum::{Display, EnumIter};
 
 use crate::framework::{
     ClusterName, IsLabelValue, ProductName, RoleName,
@@ -76,7 +76,17 @@ pub mod versioned {
     // https://github.com/opensearch-project/ml-commons/blob/3.0.0.0/plugin/src/main/java/org/opensearch/ml/plugin/MachineLearningPlugin.java#L394.
     // If such a plugin is added, then this enumeration must be extended accordingly.
     #[derive(
-        Clone, Debug, Deserialize, Display, Eq, JsonSchema, Ord, PartialEq, PartialOrd, Serialize,
+        Clone,
+        Debug,
+        Deserialize,
+        Display,
+        EnumIter,
+        Eq,
+        JsonSchema,
+        Ord,
+        PartialEq,
+        PartialOrd,
+        Serialize,
     )]
     // The OpenSearch configuration uses snake_case. To make it easier to match the log output of
     // OpenSearch with this cluster configuration, snake_case is also used here.