Fix the remaining TODOs or remove them if not necessary

Author: siegfriedweber

rust/operator-binary/src/controller/build/role_builder.rs

@@ -49,8 +49,6 @@ impl<'a> RoleBuilder<'a> {
         }
     }
 
-    // TODO Only one builder function which calls the other ones?
-
     pub fn role_group_builders(&self) -> Vec<RoleGroupBuilder<'_>> {
         self.cluster
             .role_group_configs

tests/templates/kuttl/external-access/opensearch.yaml.j2

@@ -60,16 +60,16 @@ spec:
                       annotations:
                         secrets.stackable.tech/scope: node,pod,service=opensearch-nodes-data2-headless
     envOverrides:
-      # TODO Make these the defaults in the image
+      # Only required for the official image
+      # The official image (built with https://github.com/opensearch-project/opensearch-build)
+      # installs a demo configuration if not disabled explicitly.
       DISABLE_INSTALL_DEMO_CONFIG: "true"
       OPENSEARCH_HOME: {{ test_scenario['values']['opensearch_home'] }}
     configOverrides:
-      # TODO Add the required options to the operator
       opensearch.yml:
         # Disable memory mapping in this test; If memory mapping were activated, the kernel setting
         # vm.max_map_count would have to be increased to 262144 on the node.
         node.store.allow_mmap: "false"
-        # TODO Check that this is safe despite the warning in the documentation
         plugins.security.allow_default_init_securityindex: "true"
         plugins.security.ssl.transport.enabled: "true"
         plugins.security.ssl.transport.pemcert_filepath: {{ test_scenario['values']['opensearch_home'] }}/config/tls/tls.crt
@@ -79,7 +79,6 @@ spec:
         plugins.security.ssl.http.pemcert_filepath: {{ test_scenario['values']['opensearch_home'] }}/config/tls/tls.crt
         plugins.security.ssl.http.pemkey_filepath: {{ test_scenario['values']['opensearch_home'] }}/config/tls/tls.key
         plugins.security.ssl.http.pemtrustedcas_filepath: {{ test_scenario['values']['opensearch_home'] }}/config/tls/ca.crt
-        plugins.security.authcz.admin_dn: "CN=generated certificate for pod"
     podOverrides:
       spec:
         containers:
@@ -89,11 +88,8 @@ spec:
                 mountPath: {{ test_scenario['values']['opensearch_home'] }}/config/opensearch-security
                 readOnly: true
               - name: tls
-                # The Java policy allows reading from ${OPENSEARCH_HOME}/config.
                 mountPath: {{ test_scenario['values']['opensearch_home'] }}/config/tls
                 readOnly: true
-        securityContext:
-          fsGroup: 1000
         volumes:
           - name: security-config
             secret:

tests/templates/kuttl/ldap/21-install-opensearch.yaml.j2

@@ -17,6 +17,9 @@ spec:
       default:
         replicas: 3
     envOverrides:
+      # Only required for the official image
+      # The official image (built with https://github.com/opensearch-project/opensearch-build)
+      # installs a demo configuration if not disabled explicitly.
       DISABLE_INSTALL_DEMO_CONFIG: "true"
       OPENSEARCH_HOME: {{ test_scenario['values']['opensearch_home'] }}
     configOverrides:
@@ -44,8 +47,6 @@ spec:
               - name: tls
                 mountPath: {{ test_scenario['values']['opensearch_home'] }}/config/tls
                 readOnly: true
-        securityContext:
-          fsGroup: 1000
         volumes:
           - name: security-config
             secret:

tests/templates/kuttl/metrics/20-install-opensearch.yaml.j2

@@ -38,7 +38,6 @@ spec:
         plugins.security.ssl.http.pemcert_filepath: {{ test_scenario['values']['opensearch_home'] }}/config/tls/tls.crt
         plugins.security.ssl.http.pemkey_filepath: {{ test_scenario['values']['opensearch_home'] }}/config/tls/tls.key
         plugins.security.ssl.http.pemtrustedcas_filepath: {{ test_scenario['values']['opensearch_home'] }}/config/tls/ca.crt
-        plugins.security.authcz.admin_dn: "CN=generated certificate for pod"
     podOverrides:
       spec:
         containers:
@@ -50,8 +49,6 @@ spec:
               - name: tls
                 mountPath: {{ test_scenario['values']['opensearch_home'] }}/config/tls
                 readOnly: true
-        securityContext:
-          fsGroup: 1000
         volumes:
           - name: security-config
             secret:

tests/templates/kuttl/smoke/10-assert.yaml.j2

@@ -1,7 +1,6 @@
 # All fields are checked that are set by the operator.
 # This helps to detect unintentional changes.
 # The maintenance effort should be okay as long as it is only done in the smoke test.
-# TODO  Check individual field in unit tests
 ---
 apiVersion: kuttl.dev/v1beta1
 kind: TestAssert
@@ -404,7 +403,6 @@ data:
     network.host: "0.0.0.0"
     node.store.allow_mmap: "false"
     plugins.security.allow_default_init_securityindex: "true"
-    plugins.security.authcz.admin_dn: "CN=generated certificate for pod"
     plugins.security.nodes_dn: ["CN=generated certificate for pod"]
     plugins.security.ssl.http.enabled: "true"
     plugins.security.ssl.http.pemcert_filepath: "{{ test_scenario['values']['opensearch_home'] }}/config/tls/tls.crt"
@@ -439,7 +437,6 @@ data:
     network.host: "0.0.0.0"
     node.store.allow_mmap: "false"
     plugins.security.allow_default_init_securityindex: "true"
-    plugins.security.authcz.admin_dn: "CN=generated certificate for pod"
     plugins.security.nodes_dn: ["CN=generated certificate for pod"]
     plugins.security.ssl.http.enabled: "true"
     plugins.security.ssl.http.pemcert_filepath: "{{ test_scenario['values']['opensearch_home'] }}/config/tls/tls.crt"

tests/templates/kuttl/smoke/10-install-opensearch.yaml.j2

@@ -55,16 +55,16 @@ spec:
                       annotations:
                         secrets.stackable.tech/scope: node,pod,service=opensearch-nodes-data-headless
     envOverrides:
-      # TODO Make these the defaults in the image
+      # Only required for the official image
+      # The official image (built with https://github.com/opensearch-project/opensearch-build)
+      # installs a demo configuration if not disabled explicitly.
       DISABLE_INSTALL_DEMO_CONFIG: "true"
       OPENSEARCH_HOME: {{ test_scenario['values']['opensearch_home'] }}
     configOverrides:
-      # TODO Add the required options to the operator
       opensearch.yml:
         # Disable memory mapping in this test; If memory mapping were activated, the kernel setting
         # vm.max_map_count would have to be increased to 262144 on the node.
         node.store.allow_mmap: "false"
-        # TODO Check that this is safe despite the warning in the documentation
         plugins.security.allow_default_init_securityindex: "true"
         plugins.security.ssl.transport.enabled: "true"
         plugins.security.ssl.transport.pemcert_filepath: {{ test_scenario['values']['opensearch_home'] }}/config/tls/tls.crt
@@ -74,7 +74,6 @@ spec:
         plugins.security.ssl.http.pemcert_filepath: {{ test_scenario['values']['opensearch_home'] }}/config/tls/tls.crt
         plugins.security.ssl.http.pemkey_filepath: {{ test_scenario['values']['opensearch_home'] }}/config/tls/tls.key
         plugins.security.ssl.http.pemtrustedcas_filepath: {{ test_scenario['values']['opensearch_home'] }}/config/tls/ca.crt
-        plugins.security.authcz.admin_dn: "CN=generated certificate for pod"
     podOverrides:
       spec:
         containers:
@@ -86,8 +85,6 @@ spec:
               - name: tls
                 mountPath: {{ test_scenario['values']['opensearch_home'] }}/config/tls
                 readOnly: true
-        securityContext:
-          fsGroup: 1000
         volumes:
           - name: security-config
             secret:

tests/templates/kuttl/smoke/20-test-opensearch.yaml

@@ -72,8 +72,6 @@ data:
 
     from opensearchpy import OpenSearch
 
-    # TODO Use a discovery ConfigMap
-
     host = 'opensearch'
     port = 9200
     auth = ('admin', 'AJVFsGJBbpT6mChn') # For testing only. Don't store credentials in code.