Skip to content

fix: Log file rollover - #107

Merged
siegfriedweber merged 6 commits into
mainfrom
fix/log-file-rollover
Jan 27, 2026
Merged

fix: Log file rollover#107
siegfriedweber merged 6 commits into
mainfrom
fix/log-file-rollover

Conversation

@siegfriedweber

@siegfriedweber siegfriedweber commented Jan 26, 2026

Copy link
Copy Markdown
Member

Description

Log file rollover fixed

Fixes #106

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Release note snippet added: Log file rollover fails #106 (comment)

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@siegfriedweber
siegfriedweber requested a review from a team January 26, 2026 14:44
@siegfriedweber siegfriedweber self-assigned this Jan 26, 2026
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering Jan 26, 2026
@maltesander
maltesander self-requested a review January 26, 2026 14:49
@maltesander maltesander moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jan 26, 2026
Comment thread rust/operator-binary/src/controller/build/node_config.rs Outdated
@siegfriedweber

This comment was marked as resolved.

@siegfriedweber

Copy link
Copy Markdown
Member Author

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@siegfriedweber
siegfriedweber added this pull request to the merge queue Jan 27, 2026
@siegfriedweber siegfriedweber moved this from Development: In Review to Development: Done in Stackable Engineering Jan 27, 2026
Merged via the queue into main with commit 8425d01 Jan 27, 2026
12 checks passed
@siegfriedweber
siegfriedweber deleted the fix/log-file-rollover branch January 27, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log file rollover fails

2 participants