Skip to content

Use the framework code from stackable-operator - #147

Merged
siegfriedweber merged 10 commits into
mainfrom
upgrade-stackable-operator
Jun 22, 2026
Merged

Use the framework code from stackable-operator#147
siegfriedweber merged 10 commits into
mainfrom
upgrade-stackable-operator

Conversation

@siegfriedweber

@siegfriedweber siegfriedweber commented Jun 18, 2026 •
edited by maltesander
Loading

Copy link
Copy Markdown
Member

Description

Use the framework code from stackable-operator and remove the framework module

Part of stackabletech/internal-issues#167

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@siegfriedweber siegfriedweber self-assigned this Jun 18, 2026
@siegfriedweber
siegfriedweber marked this pull request as ready for review June 19, 2026 17:18
@siegfriedweber siegfriedweber moved this to Development: Waiting for Review in Stackable Engineering Jun 19, 2026
@siegfriedweber

siegfriedweber commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

All integration tests passed on a local k3s cluster.

maltesander
maltesander previously approved these changes Jun 22, 2026
View reviewed changes

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick. LGTM!

Comment thread rust/operator-binary/src/controller/build/role_group_builder.rs Outdated
@siegfriedweber @maltesander
Update rust/operator-binary/src/controller/build/role_group_builder.rs
ed9f5e9 
Co-authored-by: maltesander <malte.sander.it@gmail.com>
@siegfriedweber siegfriedweber moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 22, 2026
@siegfriedweber

siegfriedweber commented Jun 22, 2026

Copy link
Copy Markdown
Member Author 
--- PASS: kuttl (125.34s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/logging_opensearch-3.1.0 (106.05s)
        --- PASS: kuttl/harness/logging_opensearch-3.4.0 (125.32s)

maltesander
maltesander approved these changes Jun 22, 2026
View reviewed changes

@maltesander maltesander left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@siegfriedweber siegfriedweber moved this from Development: In Review to Development: Done in Stackable Engineering Jun 22, 2026
@siegfriedweber
siegfriedweber enabled auto-merge June 22, 2026 09:55
@siegfriedweber
siegfriedweber added this pull request to the merge queue Jun 22, 2026
Merged via the queue into main with commit 080589e Jun 22, 2026
12 checks passed
@siegfriedweber
siegfriedweber deleted the upgrade-stackable-operator branch June 22, 2026 10:08
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@siegfriedweber siegfriedweber

Labels

None yet

Projects

Stackable Engineering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siegfriedweber @maltesander @lfrancke