Revise code

Author: siegfriedweber

crates/stackable-operator/src/builder/pod/volume.rs

@@ -315,9 +315,9 @@ impl SecretOperatorVolumeSourceBuilder {
 
     pub fn with_auto_tls_cert_domain_components_in_subject_dn(
         &mut self,
-        enabled: impl Into<bool>,
+        enabled: bool,
     ) -> &mut Self {
-        self.auto_tls_cert_domain_components_in_subject_dn = Some(enabled.into());
+        self.auto_tls_cert_domain_components_in_subject_dn = Some(enabled);
         self
     }
 

crates/stackable-operator/src/kvp/annotation/mod.rs

@@ -159,7 +159,7 @@ impl Annotation {
 
     /// Constructs a `autoscaling.stackable.tech/retry` annotation.
     pub fn autoscaling_retry(retry: bool) -> Self {
-        // SAFETY: We use expect here, because the input parameter can only be one of two possible
+        // PANICS: We use expect here, because the input parameter can only be one of two possible
         // values: true or false. This fact in combination with the known annotation key length
         // allows us to use expect here, instead of bubbling up the error.
         let kvp = KeyValuePair::try_from(("autoscaling.stackable.tech/retry", retry.to_string()))
@@ -169,14 +169,14 @@ impl Annotation {
 
     /// Constructs a `secrets.stackable.tech/backend.autotls.cert.domain-components-in-subject-dn` annotation.
     pub fn auto_tls_cert_domain_components_in_subject_dn(enabled: bool) -> Self {
-        // SAFETY: We use expect here, because the input parameter can only be one of two possible
+        // PANICS: We use expect here, because the input parameter can only be one of two possible
         // values: true or false. This fact in combination with the known annotation key length
         // allows us to use expect here, instead of bubbling up the error.
         let kvp = KeyValuePair::try_from((
             "secrets.stackable.tech/backend.autotls.cert.domain-components-in-subject-dn",
             enabled.to_string(),
         ))
-        .expect("annotation must be valid");
+        .expect("annotation secrets.stackable.tech/backend.autotls.cert.domain-components-in-subject-dn must be valid");
         Self(kvp)
     }
 }