chore: Remove unused code

Author: siegfriedweber

crates/stackable-operator/src/crd/git_sync/v1alpha1_impl.rs

@@ -164,7 +164,7 @@ impl GitSyncResources {
                 resolved_product_image,
                 git_sync,
                 true,
-                &Vec::from(env_vars.clone()),
+                &Vec::from(env_vars),
                 &git_sync_container_volume_mounts,
                 container_log_config,
             )?;

crates/stackable-operator/src/crd/git_sync/v1alpha2_impl.rs

@@ -258,7 +258,7 @@ impl GitSyncResources {
                 resolved_product_image,
                 git_sync,
                 true,
-                &Vec::from(env_vars.clone()),
+                &Vec::from(env_vars),
                 &git_sync_container_volume_mounts,
                 container_log_config,
                 ca_cert_path.as_deref(),
@@ -1045,7 +1045,7 @@ name: content-from-git-2
         let git_sync_resources = GitSyncResources::new(
             &git_syncs,
             &resolved_product_image,
-            &Vec::from(extra_env_vars.clone()),
+            &Vec::from(extra_env_vars),
             &extra_volume_mounts,
             "log-volume",
             &validate(default_container_log_config()).unwrap(),
@@ -1255,7 +1255,7 @@ secret:
         let git_sync_resources = GitSyncResources::new(
             &git_syncs,
             &resolved_product_image,
-            &Vec::from(extra_env_vars.clone()),
+            &Vec::from(extra_env_vars),
             &extra_volume_mounts,
             "log-volume",
             &validate(default_container_log_config()).unwrap(),

crates/stackable-operator/src/role_utils.rs

@@ -343,65 +343,6 @@ pub struct Role<
     pub role_groups: HashMap<String, RoleGroup<Config, CommonConfig, ConfigOverrides>>,
 }
 
-// impl<Config, ConfigOverrides, RoleConfig, CommonConfig>
-//     Role<Config, ConfigOverrides, RoleConfig, CommonConfig>
-// where
-//     Config: Configuration + 'static,
-//     RoleConfig: Default + JsonSchema + Serialize,
-//     CommonConfig: Default + JsonSchema + Serialize + Clone,
-//     ConfigOverrides: Default + JsonSchema + Serialize,
-// {
-//     /// This casts a generic struct implementing [`crate::product_config_utils::Configuration`]
-//     /// and used in [`Role`] into a Box of a dynamically dispatched
-//     /// [`crate::product_config_utils::Configuration`] Trait. This is required to use the generic
-//     /// [`Role`] with more than a single generic struct. For example different roles most likely
-//     /// have different structs implementing Configuration.
-//     pub fn erase(
-//         self,
-//     ) -> Role<
-//         Box<dyn Configuration<Configurable = Config::Configurable>>,
-//         ConfigOverrides,
-//         RoleConfig,
-//         CommonConfig,
-//     > {
-//         Role {
-//             config: CommonConfiguration {
-//                 config: Box::new(self.config.config)
-//                     as Box<dyn Configuration<Configurable = Config::Configurable>>,
-//                 config_overrides: self.config.config_overrides,
-//                 env_overrides: self.config.env_overrides,
-//                 cli_overrides: self.config.cli_overrides,
-//                 pod_overrides: self.config.pod_overrides,
-//                 product_specific_common_config: self.config.product_specific_common_config,
-//             },
-//             role_config: self.role_config,
-//             role_groups: self
-//                 .role_groups
-//                 .into_iter()
-//                 .map(|(name, group)| {
-//                     (
-//                         name,
-//                         RoleGroup {
-//                             config: CommonConfiguration {
-//                                 config: Box::new(group.config.config)
-//                                     as Box<dyn Configuration<Configurable = Config::Configurable>>,
-//                                 config_overrides: group.config.config_overrides,
-//                                 env_overrides: group.config.env_overrides,
-//                                 cli_overrides: group.config.cli_overrides,
-//                                 pod_overrides: group.config.pod_overrides,
-//                                 product_specific_common_config: group
-//                                     .config
-//                                     .product_specific_common_config,
-//                             },
-//                             replicas: group.replicas,
-//                         },
-//                     )
-//                 })
-//                 .collect(),
-//         }
-//     }
-// }
-
 impl<Config, ConfigOverrides, RoleConfig>
     Role<Config, ConfigOverrides, RoleConfig, JavaCommonConfig>
 where