fix/webhook): Don't crash on dropped initial_reconcile_tx channel

Author: sbernauer

crates/stackable-webhook/src/webhooks/conversion_webhook.rs

@@ -18,7 +18,7 @@ use kube::{
     Api, Client, ResourceExt,
     api::{Patch, PatchParams},
 };
-use snafu::{ResultExt, Snafu, ensure};
+use snafu::{ResultExt, Snafu};
 use tokio::sync::oneshot;
 use tracing::instrument;
 
@@ -27,9 +27,6 @@ use crate::WebhookServerOptions;
 
 #[derive(Debug, Snafu)]
 pub enum ConversionWebhookError {
-    #[snafu(display("failed to send initial CRD reconcile heartbeat"))]
-    SendInitialReconcileHeartbeat,
-
     #[snafu(display("failed to patch CRD {crd_name:?}"))]
     PatchCrd {
         source: kube::Error,
@@ -262,10 +259,8 @@ where
         // After the reconciliation of the CRDs, the initial reconcile heartbeat is sent out
         // via the oneshot channel.
         if let Some(initial_reconcile_tx) = self.initial_reconcile_tx.take() {
-            ensure!(
-                initial_reconcile_tx.send(()).is_ok(),
-                SendInitialReconcileHeartbeatSnafu
-            );
+            // TODO Some docs why we ignore errors
+            let _ = initial_reconcile_tx.send(());
         }
 
         Ok(())