Skip to content

Commit 20ad3e6

Browse files
committed
Add TODO on connection param escaping
1 parent 655e4ff commit 20ad3e6

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

  • crates/stackable-operator/src/database_connections

crates/stackable-operator/src/database_connections/helpers.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,10 @@ pub fn username_and_password_env_names(unique_database_name: &str) -> (String, S
3131
}
3232

3333
/// Returns [`None`] if no connection parameters are defined, `?key1=value1&key2=value2` otherwise.
34+
//
35+
// TODO: Do we need to escape anything here? Ideally the products themselves take care of this.
36+
// Additionally, we need to keep in mind that whatever escaping we come up with needs to be
37+
// understood by all products (which includes JDBC, SQLAlchemy and Celery connections strings).
3438
pub fn connection_parameters_as_url_query_parameters(
3539
parameters: &BTreeMap<String, String>,
3640
) -> Option<String> {

0 commit comments

Comments
 (0)