clippy::derive_partial_eq_without_eq

Author: sbernauer

crates/stackable-operator/src/builder/meta.rs

@@ -7,7 +7,7 @@ use crate::kvp::{Annotation, Annotations, Label, LabelError, Labels, ObjectLabel
 
 type Result<T, E = Error> = std::result::Result<T, E>;
 
-#[derive(Debug, PartialEq, Snafu)]
+#[derive(Debug, PartialEq, Eq, Snafu)]
 pub enum Error {
     #[snafu(display("failed to set recommended labels"))]
     RecommendedLabels { source: LabelError },

crates/stackable-operator/src/builder/pdb.rs

@@ -15,7 +15,7 @@ use crate::{
 
 type Result<T, E = Error> = std::result::Result<T, E>;
 
-#[derive(Debug, PartialEq, Snafu)]
+#[derive(Debug, PartialEq, Eq, Snafu)]
 pub enum Error {
     #[snafu(display("failed to create role selector labels"))]
     RoleSelectorLabels { source: crate::kvp::LabelError },

crates/stackable-operator/src/builder/pod/mod.rs

@@ -36,7 +36,7 @@ pub mod volume;
 
 type Result<T, E = Error> = std::result::Result<T, E>;
 
-#[derive(Debug, PartialEq, Snafu)]
+#[derive(Debug, PartialEq, Eq, Snafu)]
 pub enum Error {
     #[snafu(display("termination grace period is too long (got {duration}, maximum allowed is {max})", max = Duration::from_secs(i64::MAX as u64)))]
     TerminationGracePeriodTooLong {

crates/stackable-operator/src/builder/pod/volume.rs

@@ -41,9 +41,7 @@ pub enum VolumeSource {
 
 impl Default for VolumeSource {
     fn default() -> Self {
-        Self::EmptyDir(EmptyDirVolumeSource {
-            ..EmptyDirVolumeSource::default()
-        })
+        Self::EmptyDir(EmptyDirVolumeSource::default())
     }
 }
 
@@ -267,7 +265,7 @@ impl VolumeMountBuilder {
     }
 }
 
-#[derive(Debug, PartialEq, Snafu)]
+#[derive(Debug, PartialEq, Eq, Snafu)]
 pub enum SecretOperatorVolumeSourceBuilderError {
     #[snafu(display("failed to parse secret operator volume annotation"))]
     ParseAnnotation { source: AnnotationError },
@@ -440,7 +438,7 @@ impl ListenerReference {
 
 // NOTE (Techassi): We might want to think about these names and how long they
 // are getting.
-#[derive(Debug, PartialEq, Snafu)]
+#[derive(Debug, PartialEq, Eq, Snafu)]
 pub enum ListenerOperatorVolumeSourceBuilderError {
     #[snafu(display("failed to convert listener reference into Kubernetes annotation"))]
     ListenerReferenceAnnotation { source: AnnotationError },
@@ -490,10 +488,7 @@ pub struct ListenerOperatorVolumeSourceBuilder {
 
 impl ListenerOperatorVolumeSourceBuilder {
     /// Create a builder for the given listener class or listener name
-    pub fn new(
-        listener_reference: &ListenerReference,
-        labels: &Labels,
-    ) -> Self {
+    pub fn new(listener_reference: &ListenerReference, labels: &Labels) -> Self {
         Self {
             listener_reference: listener_reference.to_owned(),
             labels: labels.to_owned(),

crates/stackable-operator/src/cluster_resources.rs

@@ -205,10 +205,8 @@ impl ClusterResourceApplyStrategy {
     /// Indicates if orphaned resources should be deleted depending on the strategy.
     const fn delete_orphans(&self) -> bool {
         match self {
-            Self::NoApply
-            | Self::ReconciliationPaused => false,
-            Self::ClusterStopped
-            | Self::Default => true,
+            Self::NoApply | Self::ReconciliationPaused => false,
+            Self::ClusterStopped | Self::Default => true,
         }
     }
 }
@@ -261,14 +259,10 @@ impl ClusterResource for DaemonSet {
                 spec: Some(DaemonSetSpec {
                     template: PodTemplateSpec {
                         spec: Some(PodSpec {
-                            node_selector: Some(
-                                [(
-                                    "stackable.tech/do-not-schedule".to_string(),
-                                    "cluster-stopped".to_string(),
-                                )]
-                                .into_iter()
-                                .collect::<BTreeMap<String, String>>(),
-                            ),
+                            node_selector: Some(BTreeMap::from([(
+                                "stackable.tech/do-not-schedule".to_string(),
+                                "cluster-stopped".to_string(),
+                            )])),
                             ..self
                                 .spec
                                 .clone()

crates/stackable-operator/src/commons/networking.rs

@@ -143,7 +143,7 @@ impl HostName {
 }
 
 /// A validated kerberos realm name type, for use in CRDs.
-#[derive(Serialize, Deserialize, Clone, Debug, PartialEq, JsonSchema)]
+#[derive(Serialize, Deserialize, Clone, Debug, PartialEq, Eq, JsonSchema)]
 #[serde(try_from = "String", into = "String")]
 pub struct KerberosRealmName(
     // Note: Starting with schemars 1.0 and kube 2.0, this pattern is missing in the CRD

crates/stackable-operator/src/commons/pdb.rs

@@ -8,7 +8,7 @@ use serde::{Deserialize, Serialize};
 ///
 /// Learn more in the
 /// [allowed Pod disruptions documentation](DOCS_BASE_URL_PLACEHOLDER/concepts/operations/pod_disruptions).
-#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Serialize)]
+#[derive(Clone, Debug, Deserialize, JsonSchema, PartialEq, Eq, Serialize)]
 #[serde(rename_all = "camelCase")]
 pub struct PdbConfig {
     /// Whether a PodDisruptionBudget should be written out for this role.

crates/stackable-operator/src/commons/rbac.rs

@@ -12,7 +12,7 @@ use crate::{
 
 type Result<T, E = Error> = std::result::Result<T, E>;
 
-#[derive(Debug, PartialEq, Snafu)]
+#[derive(Debug, PartialEq, Eq, Snafu)]
 pub enum Error {
     #[snafu(display("failed to set owner reference from resource for ServiceAccount {name:?}"))]
     ServiceAccountOwnerReferenceFromResource {

crates/stackable-operator/src/commons/secret_class.rs

@@ -7,7 +7,7 @@ use crate::builder::pod::volume::{
     SecretOperatorVolumeSourceBuilder, SecretOperatorVolumeSourceBuilderError, VolumeBuilder,
 };
 
-#[derive(Debug, PartialEq, Snafu)]
+#[derive(Debug, PartialEq, Eq, Snafu)]
 pub enum SecretClassVolumeError {
     #[snafu(display("failed to build secret operator volume"))]
     SecretOperatorVolume {

crates/stackable-operator/src/cpu.rs

@@ -11,7 +11,7 @@ use snafu::{ResultExt, Snafu};
 
 pub type Result<T, E = Error> = std::result::Result<T, E>;
 
-#[derive(Debug, PartialEq, Snafu)]
+#[derive(Debug, PartialEq, Eq, Snafu)]
 pub enum Error {
     #[snafu(display(
         "unsupported precision {value:?}. Kubernetes doesn't allow you to specify CPU resources with a precision finer than 1m. Because of this, it's useful to specify CPU units less than 1.0 or 1000m using the milliCPU form; for example, 5m rather than 0.005"
@@ -37,7 +37,7 @@ pub enum Error {
 /// A CPU quantity cannot have a precision finer than 'm' (millis) in Kubernetes.
 /// So we use that as our internal representation (see:
 /// `<https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#meaning-of-cpu>`).
-#[derive(Debug, Clone, Copy, PartialEq, PartialOrd)]
+#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd)]
 pub struct CpuQuantity {
     millis: usize,
 }