refactor(stackable-operator): Move report_controller_error logic into the caller

Author: NickLarsenNZ

crates/stackable-operator/src/logging/controller.rs

@@ -61,23 +61,13 @@ pub async fn report_controller_reconciled<K, ReconcileErr, QueueErr>(
                 "Reconciled object"
             );
         }
-        Err(err) => report_controller_error(recorder, controller_name, err).await,
+        Err(error) => {
+            tracing::error!(
+                controller.name = controller_name,
+                error = error as &dyn std::error::Error,
+                "Failed to reconcile object",
+            );
+            publish_controller_error_as_k8s_event(recorder, error).await;
+        }
     }
 }
-
-/// Reports an error to the operator administrator and, if relevant, the end user
-async fn report_controller_error<ReconcileErr, QueueErr>(
-    recorder: &Recorder,
-    controller_name: &str,
-    error: &controller::Error<ReconcileErr, QueueErr>,
-) where
-    ReconcileErr: ReconcilerError,
-    QueueErr: std::error::Error,
-{
-    tracing::error!(
-        controller.name = controller_name,
-        error = error as &dyn std::error::Error,
-        "Failed to reconcile object",
-    );
-    publish_controller_error_as_k8s_event(recorder, error).await;
-}