clippy::implicit_hasher

Author: sbernauer

crates/stackable-operator/src/config/fragment.rs

@@ -5,7 +5,7 @@
 use std::{
     collections::{BTreeMap, HashMap},
     fmt::{Display, Write},
-    hash::Hash,
+    hash::{BuildHasher, Hash},
 };
 
 use k8s_openapi::api::core::v1::PodTemplateSpec;
@@ -134,7 +134,7 @@ impl<T: Atomic> FromFragment for T {
         fragment.ok_or_else(|| validator.error_required())
     }
 }
-impl<K, V: FromFragment> FromFragment for HashMap<K, V>
+impl<K, V: FromFragment, S: BuildHasher + Default> FromFragment for HashMap<K, V, S>
 where
     K: Eq + Hash + Display,
 {

crates/stackable-operator/src/config/merge.rs

@@ -2,7 +2,7 @@
 
 use std::{
     collections::{BTreeMap, HashMap, btree_map, hash_map},
-    hash::Hash,
+    hash::{BuildHasher, Hash},
 };
 
 use k8s_openapi::{
@@ -75,7 +75,7 @@ impl<K: Ord + Clone, V: Merge + Clone> Merge for BTreeMap<K, V> {
         }
     }
 }
-impl<K: Hash + Eq + Clone, V: Merge + Clone> Merge for HashMap<K, V> {
+impl<K: Hash + Eq + Clone, V: Merge + Clone, S: BuildHasher> Merge for HashMap<K, V, S> {
     fn merge(&mut self, defaults: &Self) {
         for (k, default_v) in defaults {
             match self.entry(k.clone()) {

crates/stackable-operator/src/lib.rs

@@ -3,7 +3,6 @@
 #![expect(clippy::missing_errors_doc)]
 #![expect(clippy::must_use_candidate)]
 #![expect(clippy::return_self_not_must_use)]
-#![expect(clippy::implicit_hasher)]
 #![expect(clippy::doc_link_with_quotes)]
 #![expect(clippy::missing_panics_doc)]
 #![expect(clippy::explicit_deref_methods)]

crates/stackable-operator/src/product_config_utils.rs

@@ -1,4 +1,7 @@
-use std::collections::{BTreeMap, HashMap};
+use std::{
+    collections::{BTreeMap, HashMap},
+    hash::BuildHasher,
+};
 
 use k8s_openapi::api::core::v1::EnvVar;
 use product_config::{ProductConfigManager, PropertyValidationResult, types::PropertyNameKind};
@@ -171,20 +174,22 @@ pub fn config_for_role_and_group<'a>(
 /// - `roles`: A map keyed by role names. The value is a tuple of a vector of `PropertyNameKind`
 ///   like (Cli, Env or Files) and [`crate::role_utils::Role`] with a boxed [`Configuration`].
 #[allow(clippy::type_complexity)]
-pub fn transform_all_roles_to_config<T, U, ProductSpecificCommonConfig>(
+pub fn transform_all_roles_to_config<T, U, ProductSpecificCommonConfig, S>(
     resource: &T::Configurable,
     roles: &HashMap<
         String,
         (
             Vec<PropertyNameKind>,
             Role<T, U, ProductSpecificCommonConfig>,
         ),
+        S,
     >,
 ) -> Result<RoleConfigByPropertyKind>
 where
     T: Configuration,
     U: Default + JsonSchema + Serialize,
     ProductSpecificCommonConfig: Default + JsonSchema + Serialize,
+    S: BuildHasher,
 {
     let mut result = HashMap::new();
 
@@ -570,8 +575,8 @@ where
 ///     env_vars_from_rolegroup_config(&rolegroup_config)
 /// );
 /// ```
-pub fn env_vars_from_rolegroup_config(
-    rolegroup_config: &HashMap<PropertyNameKind, BTreeMap<String, String>>,
+pub fn env_vars_from_rolegroup_config<S: BuildHasher>(
+    rolegroup_config: &HashMap<PropertyNameKind, BTreeMap<String, String>, S>,
 ) -> Vec<EnvVar> {
     env_vars_from(
         rolegroup_config