test(stackable-versioned): Add conversion roundtrip integration test

Author: Techassi

crates/stackable-versioned/tests/inputs/roundtrip/person_v3.json

@@ -0,0 +1,31 @@
+{
+  "kind": "ConversionReview",
+  "apiVersion": "apiextensions.k8s.io/v1",
+  "request": {
+    "uid": "c4e55572-ee1f-4e94-9097-28936985d45f",
+    "desiredAPIVersion": "test.stackable.tech/v1alpha1",
+    "objects": [
+      {
+        "apiVersion": "test.stackable.tech/v3",
+        "kind": "Person",
+        "metadata": {},
+        "spec": {
+          "username": "jdoe",
+          "firstName": "John",
+          "lastName": "Doe",
+          "gender": "Male",
+          "socials": {
+            "email": "jdoe@example.com",
+            "mastodon": "@jdoe@example.com"
+          }
+        },
+        "status": {
+          "changedValues": {
+            "downgrades": {},
+            "upgrades": {}
+          }
+        }
+      }
+    ]
+  }
+}

crates/stackable-versioned/tests/person.rs

@@ -1,6 +1,9 @@
 use std::{fs::File, path::Path};
 
-use kube::{CustomResource, core::conversion::ConversionReview};
+use kube::{
+    CustomResource,
+    core::conversion::{ConversionRequest, ConversionReview},
+};
 use schemars::JsonSchema;
 use serde::{Deserialize, Serialize};
 use stackable_versioned::versioned;
@@ -18,6 +21,24 @@ pub fn convert_via_file(path: &Path) -> (ConversionReview, ConversionReview) {
     (request, response)
 }
 
+#[allow(dead_code)]
+pub fn roundtrip_conversion_review(
+    response_review: ConversionReview,
+    desired_api_version: PersonVersion,
+) -> ConversionReview {
+    let response = response_review.response.unwrap();
+    ConversionReview {
+        types: response_review.types,
+        request: Some(ConversionRequest {
+            desired_api_version: desired_api_version.as_api_version_str().to_owned(),
+            objects: response.converted_objects,
+            types: response.types,
+            uid: response.uid,
+        }),
+        response: None,
+    }
+}
+
 #[versioned(
     version(name = "v1alpha1"),
     version(name = "v1alpha2"),

crates/stackable-versioned/tests/roundtrip.rs

@@ -0,0 +1,54 @@
+use insta::glob;
+use kube::core::response::StatusSummary;
+
+use crate::person::{Person, PersonVersion};
+
+mod person;
+
+#[test]
+fn person_v3_v1alpha1_v3() {
+    glob!("./inputs/roundtrip", "*.json", |path| {
+        // Convert from v3 to v1alpha1
+        // NOTE (@Techassi): It should be noted that the input conversion review
+        // contains a status with empty changedValues to be able to assert_eq
+        // the objects at the end. As mentioned in the actual macro code, we
+        // should avoid "polluting" the status if it is empty.
+        let (request_v1alpha1, response_v1alpha1) = person::convert_via_file(path);
+        let response = response_v1alpha1
+            .response
+            .as_ref()
+            .expect("v1alpha1 review must have a response");
+
+        assert_eq!(response.result.status, Some(StatusSummary::Success));
+
+        // Construct the roundtrip review
+        let roundtrip_review =
+            person::roundtrip_conversion_review(response_v1alpha1, PersonVersion::V3);
+
+        // Convert back to v3 from v1alpha1
+        let response_v3 = Person::try_convert(roundtrip_review);
+        let response = response_v3
+            .response
+            .as_ref()
+            .expect("v3 review must have a response");
+
+        assert_eq!(response.result.status, Some(StatusSummary::Success));
+
+        // Now let compare the object how it started out with the object which
+        // was produced through the conversion roundtrip. They must match.
+        let original_object = request_v1alpha1
+            .request
+            .as_ref()
+            .expect("v1alpha1 review must have a request")
+            .objects
+            .first()
+            .expect("there must be at least one object");
+
+        let converted_object = response
+            .converted_objects
+            .first()
+            .expect("there must be at least one object");
+
+        assert_eq!(original_object, converted_object);
+    });
+}