Skip to content

Commit 6ccec94

Browse files
sbernauerTechassi
andauthored
Update crates/stackable-operator/src/crd/listener/class/mod.rs
Co-authored-by: Techassi <git@techassi.dev>
1 parent fbeccd4 commit 6ccec94

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

  • crates/stackable-operator/src/crd/listener/class

crates/stackable-operator/src/crd/listener/class/mod.rs

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,11 @@ pub mod versioned {
6464
/// to these nodes accordingly. Some cloud providers or bare metal installations do not implement
6565
/// some of the required features.
6666
//
67-
// Pls note that we shouldn't mandate the default, but just let Kubernetes choose what to do
68-
// (currently this means defaulting to Cluster), as this sound the most future-proof to me.
69-
// Maybe in the future k8s defaults to Local if the LoadBalancer supports it
67+
// Please note that Option is used here instead of a different default traffic policy. This will be
68+
// deserialized as `None` and will thus forward the selection of the traffic policy to Kubernetes
69+
// (which currently defaults to `Cluster`). This should be the most sensible option in most cases.
70+
// There is the possibility Kubernetes will automatically choose `Local` if support for it on the
71+
// LoadBalancer has been detected.
7072
pub service_external_traffic_policy: Option<core_v1alpha1::KubernetesTrafficPolicy>,
7173

7274
/// Whether addresses should prefer using the IP address (`IP`) or the hostname (`Hostname`).

0 commit comments

Comments
 (0)